-
Notifications
You must be signed in to change notification settings - Fork 260
fix(notifications): update docs to remove yaml validation issue and some cosmetic update #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Invalid Conventional Commits DetectedThe following commits do not follow the Conventional Commits format: 9e82690 - fix(notification_channel): Remove [] from microsoft_teams heading Please update these commit messages to follow the format: Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
6 similar comments
❌ Invalid Conventional Commits DetectedThe following commits do not follow the Conventional Commits format: 9e82690 - fix(notification_channel): Remove [] from microsoft_teams heading Please update these commit messages to follow the format: Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
❌ Invalid Conventional Commits DetectedThe following commits do not follow the Conventional Commits format: 9e82690 - fix(notification_channel): Remove [] from microsoft_teams heading Please update these commit messages to follow the format: Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
❌ Invalid Conventional Commits DetectedThe following commits do not follow the Conventional Commits format: 9e82690 - fix(notification_channel): Remove [] from microsoft_teams heading Please update these commit messages to follow the format: Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
❌ Invalid Conventional Commits DetectedThe following commits do not follow the Conventional Commits format: 9e82690 - fix(notification_channel): Remove [] from microsoft_teams heading Please update these commit messages to follow the format: Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
❌ Invalid Conventional Commits DetectedThe following commits do not follow the Conventional Commits format: 9e82690 - fix(notification_channel): Remove [] from microsoft_teams heading Please update these commit messages to follow the format: Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
❌ Invalid Conventional Commits DetectedThe following commits do not follow the Conventional Commits format: 9e82690 - fix(notification_channel): Remove [] from microsoft_teams heading Please update these commit messages to follow the format: Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2846 +/- ##
=======================================
Coverage 30.56% 30.56%
=======================================
Files 104 104
Lines 28601 28601
=======================================
Hits 8741 8741
Misses 19686 19686
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
❌ Invalid Conventional Commits DetectedThe following commits do not follow the Conventional Commits format: 9e82690 - fix(notification_channel): Remove [] from microsoft_teams heading Please update these commit messages to follow the format: Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
9e82690
to
1cd259c
Compare
❌ Invalid Conventional Commits DetectedThe following commits do not follow the Conventional Commits format: 1cd259c - fix(notification_channel): Remove [] from microsoft_teams heading Please update these commit messages to follow the format: Valid types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
notes for @pranav-new-relic: changes from #2821 do work here, no integration test runs since no code files have been changed. The messaging does need some cosmetic changes though |
@vagrawal-newrelic please don't mind the noise here, needing this PR for some experimentation ... |
Description
Please include a summary of the change and which issue is fixed (if relevant).
Updated docs for notification destination and notification channel to remove yaml validation issue and some cosmetic update
Type of change
Docs update
Please delete options that are not relevant.
Checklist:
Please delete options that are not relevant.
How to test this change?
Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc
https://registry.terraform.io/providers/newrelic/newrelic/latest/docs/resources/notification_destination
Validate the changes in this URL