Skip to content

feat(alerts): Add silent alerts field to condition terms #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gffuentes
Copy link

@gffuentes gffuentes commented Apr 8, 2025

Description

Adds support for Silent Alerts field (disable_health_status_reporting) for all conditions

Go client side: newrelic/newrelic-client-go#1283

Fixes # https://new-relic.atlassian.net/browse/NR-367381

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gabe Fuentes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gffuentes gffuentes changed the title Silent alerts field feat(alerts): Add silent alerts field to condition terms Apr 8, 2025
@gffuentes gffuentes force-pushed the silent-alerts-field branch from 9f7751b to a3fcc08 Compare April 8, 2025 20:19
@gffuentes gffuentes force-pushed the silent-alerts-field branch from a3fcc08 to a20938a Compare April 8, 2025 20:21
@pranav-new-relic
Copy link
Member

Hey @gffuentes, FYI: another PR dealing in NRQL Alert Conditions, #2844, authored by your colleague at DCON, @akane0915 is probably going out tomorrow, so you might land into a bunch of merge conflicts - just wanted to let you know that you might need to go through this.

Also, I'm kinda curious to know why you've added changes to a bunch of other resources (nil default values) - if there's a specific reason to this :) we'd preferably want to have such changes in an isolated PR since this PR seems to be about alerts; but yeah, just wanted to let you know. Thanks!

@gffuentes
Copy link
Author

got it, thanks @pranav-new-relic - re: unrelated resource updated, linter was mad about those things so i thought i'd toss them in but i'll remove them if we prefer separate PRs for that kind of thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants