feat(alerts): add support for cci polling frequency field in conditions#2890
Open
feat(alerts): add support for cci polling frequency field in conditions#2890
Conversation
c970f85 to
29443ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2890 +/- ##
=======================================
Coverage 30.54% 30.54%
=======================================
Files 104 104
Lines 28704 28716 +12
=======================================
+ Hits 8768 8772 +4
- Misses 19759 19766 +7
- Partials 177 178 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
63d0900 to
d504348
Compare
akane0915
reviewed
Jun 12, 2025
d504348 to
4556ae7
Compare
8ef418e to
de6e476
Compare
de6e476 to
4f66902
Compare
| - `evaluation_delay` - (Optional) How long we wait until the signal starts evaluating. The maximum delay is 7200 seconds (120 minutes). | ||
| - `slide_by` - (Optional) Gathers data in overlapping time windows to smooth the chart line, making it easier to spot trends. The `slide_by` value is specified in seconds and must be smaller than and a factor of the `aggregation_window`. | ||
| - `signal_seasonality` - (Optional) Seasonality under which a condition's signal(s) are evaluated. Only available for baseline conditions. Valid values are: `NEW_RELIC_CALCULATION`, `HOURLY`, `DAILY`, `WEEKLY`, or `NONE`. To have New Relic calculate seasonality automatically, set to `NEW_RELIC_CALCULATION`. To turn off seasonality completely, set to `NONE`. | ||
| - `polling_frequency` - (Optional) The frequency at which the NRQL will be executed and the results will be evaluated, in seconds. Polling cannot happen more frequently than 3600 seconds (1 hour), and must be specified in whole hour increments. Example: Frequency may be 3600 seconds (1 hour), but not 5400 seconds (1.5 hours). Polling cannot happen less frequently than the duration of the warning term, critical term, or 24 hours, whichever is shortest. Example: If the warning term duration is 2 days and the critical term duration is 3 days, the polling must be no less frequent than once every 86400 seconds (24 hours). Example: If the warning term duration is 6 hours and the critical term duration is 12 hours, the polling must be no less frequent than once every 21600 seconds (6 hours). Default polling frequency will be 3600 seconds (1 hour). Only valid for NRQL conditions with CloudCost, KubernetesCost, or CloudCostEstimate event types. Conditions for these event types are evaluated in a polling fashion. |
Member
There was a problem hiding this comment.
Suggested change
| - `polling_frequency` - (Optional) The frequency at which the NRQL will be executed and the results will be evaluated, in seconds. Polling cannot happen more frequently than 3600 seconds (1 hour), and must be specified in whole hour increments. Example: Frequency may be 3600 seconds (1 hour), but not 5400 seconds (1.5 hours). Polling cannot happen less frequently than the duration of the warning term, critical term, or 24 hours, whichever is shortest. Example: If the warning term duration is 2 days and the critical term duration is 3 days, the polling must be no less frequent than once every 86400 seconds (24 hours). Example: If the warning term duration is 6 hours and the critical term duration is 12 hours, the polling must be no less frequent than once every 21600 seconds (6 hours). Default polling frequency will be 3600 seconds (1 hour). Only valid for NRQL conditions with CloudCost, KubernetesCost, or CloudCostEstimate event types. Conditions for these event types are evaluated in a polling fashion. | |
| - `polling_frequency` - (Optional) The frequency, in seconds, at which the NRQL will be executed and results evaluated. When using `polling_frequency`, consider these important points: | |
| - Default polling frequency is 3600 seconds (1 hour). | |
| - Polling cannot happen more frequently than 3600 seconds (1 hour), and must be specified in whole hour increments. For example, you can set `polling_frequency` to 3600 seconds (1 hour), but not 5400 seconds (1.5 hours). | |
| - Polling cannot happen less frequently than the duration of the warning term, critical term, or 24 hours, whichever is shortest. For instance: | |
| - If the warning term duration is 2 days and the critical term duration is 3 days, polling must be no less frequent than once every 86400 seconds (24 hours). | |
| - If the warning term duration is 6 hours and the critical term duration is 12 hours, polling must be no less frequent than once every 21600 seconds (6 hours). | |
| - `polling_frequency` is only valid for NRQL conditions with CloudCost, KubernetesCost, or CloudCostEstimate event types. Conditions for these event types are evaluated in a polling fashion. |
Optimized the text to make it visually clear :) please consider this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET
Description
Adds support for polling frequency - a new field on conditions that is part of CCI project
newrelic/newrelic-client-go#1303
Fixes # https://new-relic.atlassian.net/browse/NR-413526
Type of change
Please delete options that are not relevant.
Checklist:
Please delete options that are not relevant.
How to test this change?
The feature is has relevant FF on for 100% in staging.
Test by trying to create a condition with the new field - HAS TO BE A CCI CONDITION. example below: