Skip to content

NR-465895: config recorder check#2940

Open
rkumarregar wants to merge 2 commits intonewrelic:mainfrom
rkumarregar:NR-465895
Open

NR-465895: config recorder check#2940
rkumarregar wants to merge 2 commits intonewrelic:mainfrom
rkumarregar:NR-465895

Conversation

@rkumarregar
Copy link
Contributor

Description

We were getting errors for AWS integration when config recorder already exists in customer's account.
In this PR, we are checking first if the recorder exists then we are not creating a new recorder.

Fixes # (issue)
https://new-relic.atlassian.net/browse/NR-465895

Type of change

Added an additional check before creating recorder in customer's aws account

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Please delete options that are not relevant.

  • [ *] My commit message follows conventional commits
  • [ *] My code is formatted to Go standards
  • [ *] I have performed a self-review of my own code
  • [ *] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

This can be tested by running aws terraform deployment in one of the testing account, if all good then this prints following

  "check_log" = "Found 1 existing AWS Config Configuration Recorder(s) in region us-east-1 - Skipping creation to avoid AWS limits."
  "existing_recorders" = "default"
  "has_existing_recorder" = true
  "recorder_count" = "1"
  "region" = "us-east-1"
  "should_create_new" = false
}
newrelic_integration_details = {
  "account_id" = "*"
  "name" = "*"
  "region" = "US"
}```

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants