Skip to content

feat(dashboards): add thresholds_with_series_overrides support#2985

Open
Aashirwadjain wants to merge 16 commits intomainfrom
add-new-threholds-support
Open

feat(dashboards): add thresholds_with_series_overrides support#2985
Aashirwadjain wants to merge 16 commits intomainfrom
add-new-threholds-support

Conversation

@Aashirwadjain
Copy link
Contributor

@Aashirwadjain Aashirwadjain commented Dec 3, 2025

Description

This PR aims to add thersholds_with_series_overrides support.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

@Aashirwadjain Aashirwadjain force-pushed the add-new-threholds-support branch from 58c9e74 to f46703e Compare December 3, 2025 08:53
@Aashirwadjain Aashirwadjain force-pushed the add-new-threholds-support branch from f46703e to e072636 Compare December 5, 2025 06:48
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 17.46032% with 468 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.27%. Comparing base (98a1f7d) to head (cc0bd69).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
newrelic/structures_newrelic_one_dashboard.go 4.48% 465 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2985      +/-   ##
==========================================
- Coverage   34.66%   34.27%   -0.40%     
==========================================
  Files         107      107              
  Lines       23759    24278     +519     
==========================================
+ Hits         8237     8322      +85     
- Misses      15335    15766     +431     
- Partials      187      190       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments