fix(notifications): remove unused functions and fix linting issues#3047
Open
pranav-new-relic wants to merge 3 commits intomainfrom
Open
fix(notifications): remove unused functions and fix linting issues#3047pranav-new-relic wants to merge 3 commits intomainfrom
pranav-new-relic wants to merge 3 commits intomainfrom
Conversation
- Remove unused flattenNotificationDestinationWithScope functions - Fix shadow variable error in update function - Fix formatting (remove trailing whitespace)
Revert go version from 1.26.0 back to 1.24.0 with toolchain 1.24.11 to match the project's current Go version requirements. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3047 +/- ##
==========================================
+ Coverage 34.74% 34.78% +0.03%
==========================================
Files 112 112
Lines 24737 24712 -25
==========================================
Hits 8596 8596
+ Misses 15949 15924 -25
Partials 192 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove account_id from scope test configs to fix ConflictsWith errors - Rename err2 to lookupErr for better clarity in update/delete functions - Skip WithScope data source test requiring org-level permissions Fixes integration test failures where account_id and scope were both set, violating the mutual exclusivity constraint in the schema. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes linting issues in the notification destinations scope feature:
All lint checks and compilation now pass successfully.