Fix getAttributes UnsupportedOperationException error#33
Fix getAttributes UnsupportedOperationException error#33asllop merged 2 commits intonewrelic:masterfrom
Conversation
|
|
| return "connection"; | ||
| } | ||
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
The Github editor seems to delete the last line automatically. Can you fix this @asllop @petersanta ?
Also I always get the message
ERROR: Permission to newrelic/video-agent-android.git denied to CharlesMcD.
when I try to push from a terminal, so I did the update directly on github. Is this normal? Do I need special access to be able to push a branch?
git remote show origin seems to be OK 🤔
charlesmacduff@MacBook-Pro-de-Charles video-agent-android % git remote show origin
* remote origin
Fetch URL: git@github.com:newrelic/video-agent-android.git
Push URL: git@github.com:newrelic/video-agent-android.git
HEAD branch: master
Remote branches:
add-src-attribute tracked
develop tracked
fix/add-src-attribute tracked
master tracked
old_agent tracked
task/update-exo-2.17.0 tracked
Local branch configured for 'git pull':
master merges with remote master
Local ref configured for 'git push':
master pushes to master (up to date)
charlesmacduff@MacBook-Pro-de-Charles video-agent-android % git push -u origin fix-getAttributes-crash
ERROR: Permission to newrelic/video-agent-android.git denied to CharlesMcD.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
|
@CharlesMcD I updated the version, could you pull changes from |
|
@asllop I pulled the changes from |
If we pass a Kotlin immutable Map to the
NRVideoTracker::sendEvent(String action, Map<String, Object> attributes)function, we end up with aUnsupportedOperationExceptionerror. The function shouldn't force us to pass a mutable map, so it should always create a HashMap with what is received to ensure it can be modified internally.