Skip to content

Fix getAttributes UnsupportedOperationException error#33

Merged
asllop merged 2 commits intonewrelic:masterfrom
CharlesMcD:patch-2
Feb 10, 2025
Merged

Fix getAttributes UnsupportedOperationException error#33
asllop merged 2 commits intonewrelic:masterfrom
CharlesMcD:patch-2

Conversation

@CharlesMcD
Copy link
Contributor

@CharlesMcD CharlesMcD commented Jan 22, 2025

If we pass a Kotlin immutable Map to the NRVideoTracker::sendEvent(String action, Map<String, Object> attributes) function, we end up with a UnsupportedOperationException error. The function shouldn't force us to pass a mutable map, so it should always create a HashMap with what is received to ensure it can be modified internally.

Capture d’écran, le 2025-01-22 à 13 36 18

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ CharlesMcD
❌ asllop
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment on lines 890 to 891
return "connection";
}
} No newline at end of file
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Github editor seems to delete the last line automatically. Can you fix this @asllop @petersanta ?

Also I always get the message

ERROR: Permission to newrelic/video-agent-android.git denied to CharlesMcD.

when I try to push from a terminal, so I did the update directly on github. Is this normal? Do I need special access to be able to push a branch?

git remote show origin seems to be OK 🤔

charlesmacduff@MacBook-Pro-de-Charles video-agent-android % git remote show origin
* remote origin
  Fetch URL: git@github.com:newrelic/video-agent-android.git
  Push  URL: git@github.com:newrelic/video-agent-android.git
  HEAD branch: master
  Remote branches:
    add-src-attribute      tracked
    develop                tracked
    fix/add-src-attribute  tracked
    master                 tracked
    old_agent              tracked
    task/update-exo-2.17.0 tracked
  Local branch configured for 'git pull':
    master merges with remote master
  Local ref configured for 'git push':
    master pushes to master (up to date)
charlesmacduff@MacBook-Pro-de-Charles video-agent-android % git push -u origin fix-getAttributes-crash
ERROR: Permission to newrelic/video-agent-android.git denied to CharlesMcD.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

asllop
asllop previously approved these changes Feb 6, 2025
@asllop
Copy link
Contributor

asllop commented Feb 6, 2025

@CharlesMcD I updated the version, could you pull changes from newrelic/video-agent-android:patch-2 ?

@CharlesMcD
Copy link
Contributor Author

@asllop I pulled the changes from newrelic/video-agent-android:patch-2

@asllop asllop merged commit c3e029a into newrelic:master Feb 10, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments