Add support for profile router 'publicURLs' prop and example profile - #29
Open
struanb wants to merge 5 commits into
Open
Add support for profile router 'publicURLs' prop and example profile#29struanb wants to merge 5 commits into
struanb wants to merge 5 commits into
Conversation
Resolves two conflicts: 1. Profile.pm: validate_profile_mounts_bind had erroneous router-validation code (from a prior bad conflict resolution). Restored correct bind-mount validation (dst/src/readonly). Added publicURLs to validate_profile_routers to preserve the devel-publicURLs feature. 2. Reservation.pm: Kept devel-publicURLs' direct routers() lookup-building approach (which stores publicURLs in each route entry, required by Proxy.pm). Used candidateNetworks[0] from origin/main's improved network selection logic in lookup_container_uri. https://claude.ai/code/session_01RV7XyMR37zVv3v5JdQ5FeB
…olve-conflicts-qgrwR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.