Add NewtonSceneAPI with 2 attributes
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial single apply API just to get started. It will have more attributes eventually
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
andrewkaufman
commented
Nov 6, 2025
| ) | ||
| { | ||
| uniform double newton:maxSolverIterations = 100 ( | ||
| doc = "Maximum (constraint) solver iteration counts" |
There was a problem hiding this comment.
we want better docs strings
| ) | ||
|
|
||
| uniform double newton:timeStep = 0.005 ( | ||
| doc = """Simulation time step in seconds""" |
There was a problem hiding this comment.
we want better docs strings
| inherits = </UsdAPISchemaBase> | ||
| ) | ||
| { | ||
| uniform double newton:maxSolverIterations = 100 ( |
There was a problem hiding this comment.
@AlesBorovicka if you have feedback on using uniform here
| { | ||
| "Info": { | ||
| "Types": { | ||
| "NewtonPhysicsSceneAPI": { |
There was a problem hiding this comment.
There is a mechanism to say this only applies to Scene prims but I need to lookup how to do that.
andrewkaufman
requested review from
Milad-Rakhsha-NV,
havess and
vastsoun
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an initial implementation of #2 to test out the CI workflow now that we are public.
Checklist