-
-
Notifications
You must be signed in to change notification settings - Fork 1
chore: Log the PR number when processing comments. #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Review Buddy - General Code Review
Arey @AnkanSaha, yeh kya bachkana harkat hai? Generated by Review Buddy | Tone: roast | Language: hinglish |
⚡ Review Buddy - Performance Analysis
Bhai, performance analysis mein kya hi bolun? Ek Recommendation: Check the actual impact on performance. Use tools like # Bad example: Repeated string concatenation in a loop
output=""
for i in $(seq 1 1000);
do
output+="Iteration $i\n"
done
# Good example: Using an array to build the string efficiently
output_lines=()
for i in $(seq 1 1000);
do
output_lines+=("Iteration $i")
done
output=$(printf '%s\n' "${output_lines[@]}")Yeh code example hai, aap isko seriously mat lena. Bas yaad rakhna, coding mein optimization ka matlab hai, chote changes se bada impact. Lekin tere code mein kya hi impact hoga 'baburao aap thak gaye honge, jaake so jaiye' Generated by Review Buddy | Tone: roast | Language: hinglish |
📊 Review Buddy - Code Quality & Maintainability Analysis
🎯 Overall Benchmark: 55/100 (Needs Improvement)Code quality? Yeh code itna simple hai ki isko quality bolna hi insult hai. But let's analyze it anyway, just for fun.
But seriously, you can improve code quality in other parts of your project by:
For example: # This function calculates the factorial of a number.
# It returns -1 if the input is negative.
factorial() {
local n=$1
if [[ $n -lt 0 ]]; then
echo -1
return
fi
local result=1
for ((i=1; i<=n; i++)); do
result=$((result * i))
done
echo $result
}Overall, code quality is not applicable in this case. but remember, 'picture abhi baaki hai mere dost' and that is the bigger picture for your entire code base! Generated by Review Buddy | Tone: roast | Language: hinglish |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a log entry to make it easier to trace which PR is being processed when handling /buddy issue comments.
Changes:
- Log the PR number after overriding
PR_NUMBERinhandle_issue_comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/buddy hello, what is the issue |
|
Arey Ankan, bhai, khud hi PR bana ke, khud hi poochh rahe ho "kya issue hai?" 🤔 Lagta hai code likhte waqt dhyan bhatak gaya tha. Dekh, issue toh kuch nahi hai, bas tumhara |
|
/buddy give me the full brief about this PR |
|
Arey AnkanSaha, khud hi PR banake, khud hi bhul gaya kya? 😜 Basically, yeh PR isiliye hai ki jab bhi hum kisi PR pe comment process karein, toh log mein dikhe ki kaunse PR ke liye comment process ho raha hai. |
🚫 Review Buddy - Final Recommendation
Recommendation: REJECTBhai, yaar! Is code ki quality bahut kharab hai. Reject kar do! Reasoning:
📋 Review Checklist for Reviewers:
🎯 Next Steps:🚫 Critical issues hai - is PR ko reject karo aur major fixes ke baad dobara submit karo. Generated by Review Buddy | Tone: roast | Language: hinglish |
Summary
This change adds logging to the issue comment processing, including the PR number. This enhances debuggability.
Changes
log_infostatement to log the PR number when processing comments.Verification