Remove failing test assertions for nhnr.io domain#1268
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
Co-authored-by: leon3s <7750950+leon3s@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the not passing tests by removing them it's fail because nhnr.io is a domain i don't own anymore
Remove failing test assertions for nhnr.io domain
Aug 20, 2025
Member
|
@copilot test and clippy/fmt are failing, you have to fix it |
Co-authored-by: leon3s <7750950+leon3s@users.noreply.github.com>
Contributor
Author
Fixed both the formatting and clippy/compilation issues. The formatting problem was caused by trailing blank lines left after removing the nhnr.io assertions. The clippy issue was a missing feature dependency - when the schemars feature is enabled, ipnet also needs its schemars feature enabled to implement JsonSchema trait. Changes are in commit 93b8a9b. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes failing tests by removing test assertions that make HTTP requests to the
nhnr.iodomain, which is no longer owned by the project maintainer.Problem
Two test functions were failing because they attempted to fetch resources from
nhnr.io:sub_state()test - made requests tohttps://nhnr.io/v0.16/tests/sub_state.ymlandnhnr.io/v0.16/tests/sub_state.ymlstate_apply_include()test - made requests to dynamically generated URLs using thenhnr.iodomainThese tests were designed to verify that the application could fetch and process remote state files, but since the domain is no longer available, they consistently fail.
Solution
Removed the specific test assertions that depend on the external
nhnr.iodomain while preserving all other test functionality:nhnr.ionhnr.ioThe tests now only verify local file operations (relative paths, absolute paths) and still validate the core functionality without external dependencies.
Impact
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.