Skip to content

Remove failing test assertions for nhnr.io domain#1268

Closed
Copilot wants to merge 3 commits into
nightlyfrom
copilot/fix-25bf7fb8-b26d-480e-820b-025993bfdb6e
Closed

Remove failing test assertions for nhnr.io domain#1268
Copilot wants to merge 3 commits into
nightlyfrom
copilot/fix-25bf7fb8-b26d-480e-820b-025993bfdb6e

Conversation

Copilot AI commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

This PR fixes failing tests by removing test assertions that make HTTP requests to the nhnr.io domain, which is no longer owned by the project maintainer.

Problem

Two test functions were failing because they attempted to fetch resources from nhnr.io:

  • sub_state() test - made requests to https://nhnr.io/v0.16/tests/sub_state.yml and nhnr.io/v0.16/tests/sub_state.yml
  • state_apply_include() test - made requests to dynamically generated URLs using the nhnr.io domain

These tests were designed to verify that the application could fetch and process remote state files, but since the domain is no longer available, they consistently fail.

Solution

Removed the specific test assertions that depend on the external nhnr.io domain while preserving all other test functionality:

  • sub_state() test: Removed 6 assertions that tested remote URL functionality with nhnr.io
  • state_apply_include() test: Removed 4 assertions that tested both short-form and full HTTPS URLs with nhnr.io

The tests now only verify local file operations (relative paths, absolute paths) and still validate the core functionality without external dependencies.

Impact

  • Tests no longer fail due to unreachable external domain
  • All other test functionality remains intact
  • Local file processing tests continue to work as expected
  • No breaking changes to application functionality

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: leon3s <7750950+leon3s@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the not passing tests by removing them it's fail because nhnr.io is a domain i don't own anymore Remove failing test assertions for nhnr.io domain Aug 20, 2025
Copilot AI requested a review from 0xle0ne August 20, 2025 11:52
@0xle0ne

0xle0ne commented Aug 20, 2025

Copy link
Copy Markdown
Member

@copilot test and clippy/fmt are failing, you have to fix it

Co-authored-by: leon3s <7750950+leon3s@users.noreply.github.com>

Copilot AI commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

@copilot test and clippy/fmt are failing, you have to fix it

Fixed both the formatting and clippy/compilation issues. The formatting problem was caused by trailing blank lines left after removing the nhnr.io assertions. The clippy issue was a missing feature dependency - when the schemars feature is enabled, ipnet also needs its schemars feature enabled to implement JsonSchema trait. Changes are in commit 93b8a9b.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • nanocl.internal
    • Triggering command: /home/REDACTED/work/nanocl/nanocl/target/debug/deps/nanocld_client-05579889221a6957 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants