fix npm run build:lang#545
Open
nickchomey wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves compatibility with the Google Closure Compiler and addresses type handling in the build process. The main changes include updating the compiler dependency, adding and later stripping JSDoc typedefs, and refining type references to prevent build warnings.
Dependency update:
google-closure-compilerdependency inpackage.jsonto the latest version for improved compatibility and bug fixes.Type definitions and build process enhancements:
Index,Document,WorkerIndex,Encoder,StorageInterface) insrc/type.jsto provide type information for Closure Compiler when imports are stripped.task/build.jsto automatically remove both imports and the newly added JSDoc typedefs fromtmp/type.jsduring the build process, and to replace type references withObjector*to avoid Closure Compiler "Unknown type" warnings.Type signature adjustment:
replacerproperty in theEncoderSplitOptionstypedef to accept any array, improving flexibility and compatibility.