Skip to content

fix npm run build:lang#545

Open
nickchomey wants to merge 1 commit into
nextapps-de:masterfrom
nickchomey:fix-build
Open

fix npm run build:lang#545
nickchomey wants to merge 1 commit into
nextapps-de:masterfrom
nickchomey:fix-build

Conversation

@nickchomey

Copy link
Copy Markdown

This pull request improves compatibility with the Google Closure Compiler and addresses type handling in the build process. The main changes include updating the compiler dependency, adding and later stripping JSDoc typedefs, and refining type references to prevent build warnings.

Dependency update:

  • Updated the google-closure-compiler dependency in package.json to the latest version for improved compatibility and bug fixes.

Type definitions and build process enhancements:

  • Added JSDoc typedefs for key types (Index, Document, WorkerIndex, Encoder, StorageInterface) in src/type.js to provide type information for Closure Compiler when imports are stripped.
  • Modified the build script in task/build.js to automatically remove both imports and the newly added JSDoc typedefs from tmp/type.js during the build process, and to replace type references with Object or * to avoid Closure Compiler "Unknown type" warnings.

Type signature adjustment:

  • Relaxed the type for the replacer property in the EncoderSplitOptions typedef to accept any array, improving flexibility and compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant