Open
Conversation
Sliding up triggers a click event, resulting in repeated dispatch calls, sometimes right after closing the gallery, messing up things. Using a node as media messes up the styles of the original node.
Preserve original styling of the original node fragment. Do not zoom in when users scroll horizontally. Add demonstration of scroll/pan conflicts with some special inner nodes.
|
I just included the minified built js from this PR in a project and am happy that it works perfectly. Thanks @gudzpoz! @ts-thomas any chance of a new version with this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following features:
Well, since this PR contains several distinct features, ideally it should be separated into several PRs. I can do that if it is considered necessary.
resolves #76, partially resolves #80 and maybe #44