Skip to content

Feature: sveltekit demo refactor #12287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ganxiaozhe
Copy link

☕️ Reasoning

This PR focuses on improving the UI/UX of the SvelteKit example app under ./apps/examples/sveltekit/. The changes include:

  • Refactored and modernized the overall UI design
  • Enhanced user experience and interaction flows
  • Improved responsive layouts and components
  • Updated styling to better match NextAuth.js branding
  • Optimized code structure and organization

These changes aim to provide a better demonstration of NextAuth.js integration with SvelteKit, making it easier for developers to understand and implement authentication in their SvelteKit applications.

🧢 Checklist

  • Documentation
    • Added explanatory notes for key implementation details
  • Tests
    • Manually tested all UI components and interactions
    • Verified authentication flows work as expected
  • Ready to be merged

🎫 Affected issues

This PR primarily focuses on improving the example implementation rather than fixing specific issues. However, it indirectly helps with better documentation and demonstration of NextAuth.js with SvelteKit.

📌 Resources

I have reviewed and followed:

Preview

CleanShot 2024-11-24 at 15 06 19@2x

Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Feb 2, 2025 11:12am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2025 11:12am

Copy link

vercel bot commented Nov 24, 2024

@ganxiaozhe is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

socket-security bot commented Nov 24, 2024

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@auth/[email protected] Transitive: network +1 1.89 MB balazsorban
npm/@inkeep/[email protected] Transitive: environment, filesystem, network, shell, unsafe +30 23 MB sarah-inkeep
npm/@mikro-orm/[email protected] environment, eval, filesystem, unsafe 0 888 kB b4nan
npm/@mikro-orm/[email protected] filesystem +1 354 kB b4nan
npm/@miniflare/[email protected] filesystem, unsafe Transitive: environment, eval, network, shell +6 470 kB wrangler-publisher
npm/@neondatabase/[email protected] network 0 350 kB pffigueiredo
npm/@next/[email protected] None 0 14.2 kB vercel-release-bot
npm/@playwright/[email protected] None 0 25.3 kB dgozman-ms
npm/@preact/[email protected] Transitive: environment, filesystem, unsafe +39 10.9 MB rschristian
npm/@prettier/[email protected] environment 0 349 kB shinigami92
npm/@prisma/[email protected] environment, filesystem, shell 0 8.43 MB prismabot
npm/@prisma/[email protected] None 0 62.8 kB prismabot
npm/@radix-ui/[email protected] None +14 349 kB chancestrickland
npm/@radix-ui/[email protected] None +14 332 kB chancestrickland
npm/@simplewebauthn/[email protected] None 0 42 kB iamkale
npm/@solidjs/[email protected] None 0 20.4 kB ryansolid
npm/@supabase/[email protected] network +6 2.23 MB kiwicopple
npm/@sveltejs/[email protected] environment, filesystem, shell 0 7.03 kB svelte-admin
npm/@sveltejs/[email protected] environment 0 7.22 kB svelte-admin
npm/@sveltejs/[email protected] environment 0 7.41 kB svelte-admin
npm/@sveltejs/[email protected] environment, eval +1 741 kB svelte-admin
npm/@sveltejs/[email protected] environment, eval +1 747 kB svelte-admin
npm/@sveltejs/[email protected] None 0 29.1 kB svelte-admin
npm/@sveltejs/[email protected] None +1 152 kB svelte-admin
npm/@tailwindcss/[email protected] None 0 110 kB adamwathan
npm/@types/[email protected] None +2 250 kB types
npm/@types/[email protected] None 0 13.8 kB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 3.56 MB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 2.03 MB types
npm/@types/[email protected] None 0 88.9 kB types
npm/[email protected] environment, eval, filesystem, network, shell, unsafe 0 3.26 MB vitebot

🚮 Removed packages: npm/@auth/[email protected], npm/@auth/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@vercel/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@ndom91
Copy link
Member

ndom91 commented Nov 26, 2024

This is awesome, thanks!

1 request though, can we use runes in the svelte components? I believe I saw bits-ui release a svelte-5 compatible version recently, so shadcn-svelte should be compatible, no

Copy link

stale bot commented Jan 31, 2025

It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks!

@stale stale bot added the stale Did not receive any activity for 60 days label Jan 31, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we moving the components in the lib folder though?

@stale stale bot removed the stale Did not receive any activity for 60 days label Feb 2, 2025
@ThangHuuVu
Copy link
Member

let's merge this and improve the rune thingy later on! @ndom91

@ndom91
Copy link
Member

ndom91 commented Feb 2, 2025

let's merge this and improve the rune thingy later on! @ndom91

Yup, let's do it. Looks like there's still a lock file issue though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants