-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Feature: sveltekit demo refactor #12287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature: sveltekit demo refactor #12287
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@ganxiaozhe is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
This is awesome, thanks! 1 request though, can we use runes in the svelte components? I believe I saw bits-ui release a svelte-5 compatible version recently, so shadcn-svelte should be compatible, no |
It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we moving the components in the lib folder though?
let's merge this and improve the rune thingy later on! @ndom91 |
Yup, let's do it. Looks like there's still a lock file issue though |
☕️ Reasoning
This PR focuses on improving the UI/UX of the SvelteKit example app under
./apps/examples/sveltekit/
. The changes include:These changes aim to provide a better demonstration of NextAuth.js integration with SvelteKit, making it easier for developers to understand and implement authentication in their SvelteKit applications.
🧢 Checklist
🎫 Affected issues
This PR primarily focuses on improving the example implementation rather than fixing specific issues. However, it indirectly helps with better documentation and demonstration of NextAuth.js with SvelteKit.
📌 Resources
I have reviewed and followed:
Preview