Skip to content

fix: conditionally skipping of certain steps in setup-fw-integration script to avoid script error #12843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sandheep45
Copy link

@sandheep45 sandheep45 commented Apr 3, 2025

☕️ Reasoning

Summary of Changes

  1. Handled missing providers folder gracefully

    • Previously, fs.rm was called directly, which could throw an error if the folder didn’t exist.
    • Now, it first checks for folder existence using fs.access and only attempts deletion if the folder is found.
    • If the folder doesn’t exist, a message is logged instead of throwing an error.
  2. Fixed potential issue with vercelJson.redirects merging

    • Updated to ensure that redirects is properly merged by using a fallback to an empty array when redirects is undefined.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@sandheep45 sandheep45 requested a review from ThangHuuVu as a code owner April 3, 2025 13:55
Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 1:59pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 1:59pm

Copy link

vercel bot commented Apr 3, 2025

@sandheep45 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant