Skip to content

fix: 🏷️ Include types required by solid-start framework #8302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tsdevau
Copy link

@tsdevau tsdevau commented Aug 11, 2023

☕️ Reasoning

Adding types & interfaces previously referenced from an un-included dependency (next-auth/react) to client.ts for the framework solid-start.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: #8301

📌 Resources

Include types required by solid-start framework that are currently imported from `next-auth/react`, which is not a dependency of the solid-start framework.  This provides the referenced types directly in the framework's client.ts and builds to client.d.ts.
@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 11:55pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2023 11:55pm

@vercel
Copy link

vercel bot commented Aug 11, 2023

@jdold07 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

stale bot commented Jan 31, 2025

It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks!

@stale stale bot added the stale Did not receive any activity for 60 days label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frameworks solidjs stale Did not receive any activity for 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solid-start framework is importing types from "next-auth/react"
1 participant