Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change db_table to db_name as it makes more sense #10

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Change db_table to db_name as it makes more sense #10

merged 2 commits into from
Jan 12, 2022

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jan 12, 2022 •
edited
Loading

And update documentation for db_type and scan_action

@artonge artonge self-assigned this Jan 12, 2022
@artonge artonge requested a review from mgallien January 12, 2022 12:52
@artonge artonge force-pushed the fix/db_name_nomenclature branch from 8eafffd to 26f5afe Compare January 12, 2022 13:15
mgallien
mgallien reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@artonge artonge force-pushed the fix/db_name_nomenclature branch from 8e1cc94 to d38c8b4 Compare January 12, 2022 14:23
@artonge artonge requested a review from mgallien January 12, 2022 14:23
@artonge
Copy link
Collaborator Author

artonge commented Jan 12, 2022 •
edited
Loading

Comments addressed :)

@artonge artonge merged commit 1e2173b into master Jan 12, 2022
@mgallien mgallien deleted the fix/db_name_nomenclature branch January 12, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@artonge artonge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @mgallien