fix(solvable_files): Fix quotes in sql statement of gf-pgsql case #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SQL single quotes must be used to surround a literal string. The path in this case is a literal string and must be quoted. The whole CONVERT_FROM statement however is not a literal string. Therefore it should not be surrounded by single quotes. In the case for normal users and pgsql the quotes are correct.
artonge
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SQL single quotes must be used to surround a literal string.
The path in this case is a literal string and must be quoted.
The whole
CONVERT_FROMstatement however is not a literal string.Therefore it should not be surrounded by single quotes.
In the case for normal users and pgsql the quotes are correct.
Resolves: #14