update mtime with the mtime from the database #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: szaimen <[email protected]>
artonge
reviewed
Feb 2, 2022
| @@ -112,7 +112,7 @@ function correct_mtime() { | |||
|
|
|||
| if [ "$action" == "fix" ] | |||
| then | |||
| touch -c "$filepath" | |||
| touch -c "$filepath" -m -d "$(date --date @"$mtime_in_db")" | |||
There was a problem hiding this comment.
If we do that, then the mtime won't change as it is the same in the DB and on the FS. See:
mtime_fixer_tool_kit/solvable_files.sh
Line 105 in 0851283
Did you have a situation where this would make sense?
There was a problem hiding this comment.
The question was how we could solve this?
https://help.nextcloud.com/t/why-is-23-0-1-so-heavily-delayed/132133/28
There was a problem hiding this comment.
Ok, I understand the motivation, but as the mtime is lost on both sides, db and fs, then this will not help.
There was a problem hiding this comment.
The only option is to restore the mtime from a backup. But it is out of the scope of this tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: szaimen [email protected]