Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the use case of the user being 'apache' not 'www-data'. #24

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

camilasan
Copy link
Collaborator

@camilasan camilasan commented Feb 4, 2022

I am adding this script because we bumped into a customer that uses 'apache' and not 'www-data'. I already sent this version to the customer via support.

Was there a reason to not pick up the user via script parameter @artonge?

Maybe we can just keep this extra script.

@camilasan camilasan requested review from mgallien and artonge February 4, 2022 13:57
@artonge
Copy link
Collaborator

artonge commented Feb 4, 2022

No reason beside not adding yet another arg.

Keeping two scripts will lead to discrepancies. I can accept a change guessing the username with something like:

			sudo -u "$(stat -c '%U' ./occ)" php ./occ files:scan --quiet --path="$relative_filepath"

@camilasan camilasan force-pushed the change-user-to-apache branch from 3db8d40 to 82dc746 Compare February 6, 2022 12:22
@camilasan
Copy link
Collaborator Author

Keeping two scripts will lead to discrepancies. I can accept a change guessing the username with something like:

I have changed it, please check.

@artonge artonge merged commit ec32f9a into master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants