Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an extra arg to possibly also scan the corrected files #7

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

mgallien
Copy link
Contributor

Signed-off-by: Matthieu Gallien [email protected]

@mgallien mgallien requested a review from artonge January 10, 2022 18:04
@artonge
Copy link
Collaborator

artonge commented Jan 10, 2022

I thought about this, but I think that most cases if not all cases will not benefit from it as it will slow down the script way too much. So not a good idea to offer this feature. Do you have a request for it ?

@mgallien
Copy link
Contributor Author

I thought about this, but I think that most cases if not all cases will not benefit from it as it will slow down the script way too much. So not a good idea to offer this feature. Do you have a request for it ?

Imagine a case where the server has way many files but only a few ones are affected by the wrong date bug. I guess in that case we would benefit from this.
So I would like to be able to suggest that in cases where only a few files are affected.

@mgallien
Copy link
Contributor Author

@artonge, if it is off by default I guess it will be better to be able to use it for cases where storage has many files but only 0.1% are affected

@mgallien
Copy link
Contributor Author

@artonge is it good now ?
I will need it today (if you agree)

@artonge artonge merged commit 23ef2b3 into master Jan 11, 2022
@mgallien mgallien deleted the mayRunFilesScan branch January 12, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants