[next] feat: Add consistent variant prop for design variant of buttons / chips
#6595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
added
enhancement
susnux
force-pushed
the
backport/6472/next
branch
from
e48528b to
90d9da8
Compare
susnux
approved these changes
Apr 1, 2025
susnux
force-pushed
the
backport/6472/next
branch
2 times, most recently
from
803c75e to
477ebf0
Compare
3 tasks
ShGKme
approved these changes
Apr 2, 2025
Deprecate `type` for usage with the color variant. Also deprecate `nativeType` in favor of `type` and `variant`. Signed-off-by: Ferdinand Thiessen <[email protected]>
This is done to align with `NcButton`. Signed-off-by: Ferdinand Thiessen <[email protected]>
To align with `NcButton`. Signed-off-by: Ferdinand Thiessen <[email protected]>
…`type` prop To align with `NcButton`. Signed-off-by: Ferdinand Thiessen <[email protected]>
…e` prop To align with `NcButton`. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
backport/6472/next
branch
from
477ebf0 to
47c8682
Compare
|
rebased to fix conflicts. No code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6472
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.