feat: enforce no-new-privileges for non-root containers#8018
Open
feat: enforce no-new-privileges for non-root containers#8018
Conversation
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/486c681f-f240-4505-9fc9-b143b50348f5 Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
szaimen
April 28, 2026 18:35
View session
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
security-opt: no-new-privileges:trueto all AIO-managed containers confirmed to run as a non-root user, preventing privilege escalation via setuid/setgid binaries.Changes
containers-schema.json– Addedno_new_privilegesboolean field to the container definition schemaContainer.php– AddednoNewPrivilegesbool propertyContainerDefinitionFetcher.php– Readsno_new_privilegesfrom JSON and passes it toContainerDockerActionManager.php– BuildsSecurityOptarray incrementally; appendsno-new-privileges:truewhen set. Also fixes the Collabora seccomp case to append to the existing array rather than overwrite it (preservinglabel:disableandno-new-privileges)containers.json– Added"no_new_privileges": trueto all 12 confirmed non-root containers:Containers that legitimately run as root (
nextcloud,borgbackup,watchtower,onlyoffice,docker-socket-proxy) and the externally-managedharpimage are intentionally excluded.