#7815 Delayed synchronization

[BatPio]

Fixes #7815
Fixes #2323

• Tests written, or not not needed
  Some tests are written. I'm waiting for suggestions on what else can be tested.

Delay configuration:

[codecov]

Codecov Report

Merging #11278 (3d40c3a) into master (aeb1632) will increase coverage by 0.07%.
The diff coverage is 37.20%.

❗ Current head 3d40c3a differs from pull request most recent head 501d1fe. Consider uploading reports for the commit 501d1fe to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #11278      +/-   ##
============================================
+ Coverage     31.44%   31.52%   +0.07%     
- Complexity     3413     3427      +14     
============================================
  Files           575      577       +2     
  Lines         42018    42146     +128     
  Branches       5660     5664       +4     
============================================
+ Hits          13214    13286      +72     
- Misses        26861    26905      +44     
- Partials       1943     1955      +12     

Impacted Files	Coverage Δ
...com/nextcloud/client/database/NextcloudDatabase.kt	100.00% <ø> (ø)
...cloud/client/database/entity/SyncedFolderEntity.kt	0.00% <0.00%> (ø)
...java/com/nextcloud/client/di/ComponentsModule.java	0.00% <ø> (ø)
...in/java/com/nextcloud/client/jobs/FilesSyncWork.kt	21.95% <0.00%> (-0.18%)	⬇️
...loud/android/datamodel/FilesystemDataProvider.java	4.39% <0.00%> (-0.10%)	⬇️
...oud/android/datamodel/SyncedFolderDisplayItem.java	35.29% <ø> (ø)
...ncloud/android/datamodel/SyncedFolderProvider.java	10.93% <0.00%> (-0.18%)	⬇️
...ain/java/com/owncloud/android/db/ProviderMeta.java	100.00% <ø> (ø)
...cloud/android/ui/activity/SyncedFoldersActivity.kt	20.43% <0.00%> (-0.55%)	⬇️
.../dialog/SyncedFolderPreferencesDialogFragment.java	0.00% <0.00%> (ø)
... and 11 more

[AlvaroBrey]

I haven't tested this yet, especially to see how this will behave with existing autoupload folders. This can't be tested without adressing my first comment below, however.

Having said that, this looks quite promising! Thanks for contributing @BatPio

[jancborchardt]

When reading through the linked issues #7815 and #2323 – it seems that if we implement this delay setting at all, then it should be only there when auto upload is set to "Delete after upload".
Also, instead of a flexible time picker, we should do it like elsewhere in Nextcloud and have some reasonable presets. E.g.:

• Upload immediately (default)
• 15 minutes
• 30 minutes
• 1 hour
• 24 hours
• 1 week

These presets already seem to cover all the cases brought up in the issues, without detailed time configuration needed.

"Send later" in Nextcloud Mail	"Clear status after"-picker in online status

Do you see other solutions here, especially ones which don’t add another customizable setting but just do it automatically? @tobiasKaminsky @alperozturk96 @ZetaTom

[PhilLab]

Re @jancborchardt

When reading through the linked issues #7815 and #2323 – it seems that if we implement this delay setting at all, then it should be only there when auto upload is set to "Delete after upload".

I think this feature also makes a ton of sense without auto deletion. It allows you to clean up the taken photos before they hit the cloud. Think of taking 5 photos of the same scene, where you then immediately delete those where people have their eyes closed, etc...

So it should be available for all upload types

[jancborchardt]

@PhilLab ah, thanks for the note, good point.

Then it should just be changed to the suggested intervals as mentioned.

[BatPio]

@ZetaTom @jancborchardt
Thank you for the code review, I made changes

@ZetaTom
You are right, the phrase "Delay file upload" can be misleading. I changed it to "Minimum file age"

@jancborchardt
I replaced DurationPicker with a list with fixed values

After combining both ideas:

Since the sync interval in Android is 15 minutes, I think this value is not useful. Instead, I would add values of 6 hours and 3 days

[jancborchardt]

Since the sync interval in Android is 15 minutes, I think this value is not useful. Instead, I would add values of 6 hours and 3 days

@BatPio sure, sounds good. :) Also, the wording of "No restrictions" could be changed to "Upload immediately" which might be a bit more clear?

[jancborchardt]

Looks good from the design side now. :)

[BatPio]

@alperozturk96

I've reworked the UI as suggested by @jancborchardt . Could you please review the changes?