-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Check Auto Upload Sub Folder #14547
base: master
Are you sure you want to change the base?
Conversation
alperozturk96
commented
Feb 13, 2025
•
edited
Loading
edited
- Tests written, or not not needed
2bb8991
to
3bc227d
Compare
96caffc
to
ff29eb2
Compare
2d57ed3
to
0b2f161
Compare
as discussed
|
0b2f161
to
f68d67b
Compare
Info image button added to the auto upload page. @ZetaTom @tobiasKaminsky Please review fff.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In both cases where it appears – but especially when clicking the info "i" icon – it would be more fitting to use a modal since the info is more important than to just show it in a toast.
2a713f7
to
c0130f9
Compare
c0130f9
to
9d0783e
Compare
if (titleIconId == defaultTitleIconId) { | ||
builder | ||
.setIcon(titleIconId) | ||
.setIconAttribute(R.attr.alertDialogIcon) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only setIconAttribute for defaultTitleIconId otherwise it will override given titleIconId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments @alperozturk96! :)
Signed-off-by: alperozturk <[email protected]>
…isplayItem> Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
55b01f9
to
6b78844
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14547.apk |