Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Try-With-Resources #14583

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use of Try-With-Resources #14583

wants to merge 3 commits into from

Conversation

alexknop
Copy link
Collaborator

Problem:

Manual cleanup code is used for resources that can be automatically managed.

Solution:

Use of Try-With-Resources to enhance the overall stability, performance, and clarity of code, ensuring better resource management and minimizing potential issues related to improper resource handling.

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Alex Knop added 3 commits March 11, 2025 10:45
Signed-off-by: Alex Knop <[email protected]>
Signed-off-by: Alex Knop <[email protected]>
Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

SpotBugs increased!

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14583.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants