Don't Use Raw Bitmaps for Thumbnails #14628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
force-pushed
the
dont-use-raw-bitmap-for-thumbnails
branch
3 times, most recently
from
fbf4dbc to
88c7e90
Compare
app/src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java
Outdated
Show resolved
Hide resolved
alperozturk96
force-pushed
the
dont-use-raw-bitmap-for-thumbnails
branch
2 times, most recently
from
04c6416 to
63dc791
Compare
alperozturk96
commented
Mar 19, 2025
| this.listener = listener; | ||
| } | ||
|
|
||
| public String getImageKey() { |
There was a problem hiding this comment.
Unused function
tobiasKaminsky
approved these changes
Mar 19, 2025
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
dont-use-raw-bitmap-for-thumbnails
branch
from
63dc791 to
88de95a
Compare
Signed-off-by: alperozturk <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14628.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using raw bitmaps for media thumbnails, which resulted in lag and problematic scrolling performance. Additionally, with the multi-select feature for each binding, resetting the large thumbnails led to significant delays. To address these issues, downscaling has been implemented in this pull request to improve performance.
Before
before.mp4
After
after.mp4