Move or Copy files: Start in the parent folder instead of root #15925
Conversation
PhilLab
force-pushed
the
move_or_copy_files_parent
branch
from
7ad5d3b to
283dd44
Compare
| if (isBackPressed && query.isEmpty()) { | ||
| activity.resetSearchView() | ||
| activity.updateListOfFilesFragment(true) | ||
| activity.updateListOfFilesFragment() |
There was a problem hiding this comment.
Note to reviewer: This is the only instance where the parameter was true. It didn't have any effect anymore - but maybe something specific was desired here and got lost over time?
|
Let me know if a ticket shall be created to track the behavior change |
Previous behavior always moved up to the root folder, which meant the user lost the context of their current files. Especially in complicated nested folder structures, this made standard operations overly complicated, like duplicating in the same folder or duplicating/moving to a sibling folder. This is now also in sync with the behavior of the iOS app and the web UI Signed-off-by: Philipp Hasper <[email protected]>
Last usage of the argument inside of the method was removed in 905222c, so removing it doesn't have any impact on the behavior. The only instance where the parameter was set to `true` was in the ExtendedListFragment Signed-off-by: Philipp Hasper <[email protected]>
PhilLab
force-pushed
the
move_or_copy_files_parent
branch
from
283dd44 to
35e3634
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
1 participant
Previous behavior always moved up to the root folder, which meant the user
lost the context of their current files. Especially in complicated nested
folder structures, this made standard operations overly complicated, like
duplicating in the same folder or duplicating/moving to a sibling folder.
This is now also in sync with the behavior of the iOS app and the web UI