perf(appointments): reduce bundle size bloat by @nextcloud/vue#7671
Open
ChristophWurst wants to merge 1 commit intomainfrom
Open
perf(appointments): reduce bundle size bloat by @nextcloud/vue#7671ChristophWurst wants to merge 1 commit intomainfrom
ChristophWurst wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7671 +/- ##
==========================================
- Coverage 10.88% 10.88% -0.01%
==========================================
Files 327 327
Lines 62920 62928 +8
Branches 902 902
==========================================
Hits 6847 6847
- Misses 55934 55942 +8
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tcitworld
reviewed
Nov 5, 2025
|
|
||
| <script> | ||
| import { NcEmptyContent as EmptyContent } from '@nextcloud/vue' | ||
| import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent' |
Member
There was a problem hiding this comment.
It's used as EmptyContent, not NcEmptyContent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
From https://stable8--nextcloud-vue-components.netlify.app/
The appointments scripts are small and standalone. They use a few nextcloud/vue components. On main we include the full nextcloud/vue. It will not be tree shaken.
Comparison
Before
After