Skip to content

feat: migrate to vue 3#7697

Open
SebastianKrupinski wants to merge 6 commits intomainfrom
feat/vue3-migration
Open

feat: migrate to vue 3#7697
SebastianKrupinski wants to merge 6 commits intomainfrom
feat/vue3-migration

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Nov 15, 2025

Summary

Testing

  • checkout branch
  • delete existing node_modules directory
  • npm ci && npm run dev

@SebastianKrupinski
Copy link
Contributor Author

Initial testable vue 3 migration

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues I found while poking around:

Image Image Image Image Image Image

@GVodyanov
Copy link
Contributor

Fixed this:

Before After
image image

@GVodyanov
Copy link
Contributor

I added the new datepicker, however it requires this: nextcloud-libraries/nextcloud-vue#8009

@SebastianKrupinski SebastianKrupinski force-pushed the feat/vue3-migration branch 2 times, most recently from 97eba73 to a24efcb Compare February 5, 2026 15:18
@SebastianKrupinski SebastianKrupinski added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 5, 2026
@SebastianKrupinski SebastianKrupinski changed the title migrate to vue 3 feat: migrate to vue 3 Feb 5, 2026
Copy link
Contributor

@DerDreschner DerDreschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the following issues (using Firefox, btw):

  • Creating a new event, editing an existing one or viewing a read-only one doesn't show the option to select/show the calendar the event is being created on. For that reason, the buttons at the top right side stick out into the title field when using the quick view:
Pictures Image Image image
  • The menu doesn't close when clicking on an item in the follow cases:
    • Creating a new calendar (only exception: add public holiday calendar)
    • Adding a file to an event (both upload and select existing file)
    • Editing an reminder (only closes when removing reminder -> no more reminders there afterwards)
Example picture Image
  • When using the day view and having multiple events at the same time, it looks pretty odd? Somethings wrong there.
Picture Image
  • When opening "Add public holiday calendar" and "Repeat event", there is a new text in the top middle? But only in those cases? Don't know if that's desired, it irrated me as that are the only two cases an modal overlay creates that.
Pictures Image Image
  • When editing the first notification of an event, the menu button sticks out into the drop-down selection field:
Picture Image
  • The input fields are not on the same line of sight here:
Pictures Image Image

@DerDreschner
Copy link
Contributor

Ohh, and the overlay for picking an existing file to attach to an event has the same issue with the "pick" button not having any borders/styling.

Example picture Image

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: Grigory V <scratchx@gmx.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
Copy link
Contributor Author

SebastianKrupinski commented Feb 5, 2026

Thanks for testing @DerDreschner !

The styling issues will be addressed in a few follow up PR's as per our team call conversation. There is also one issue that seems to be caused by a broken upstream component.

Style issues

  • When editing the first notification of an event, the menu button sticks out into the drop-down selection field:
  • The input fields are not on the same line of sight here:
  • Ohh, and the overlay for picking an existing file to attach to an event has the same issue with the "pick" button not having any borders/styling.

New to vue 9

  • When opening "Add public holiday calendar" and "Repeat event", there is a new text in the top middle? But only in those cases? Don't know if that's desired, it irrated me as that are the only two cases an modal overlay creates that.

Fixed

  • Creating a new event, editing an existing one or viewing a read-only one doesn't show the option to select/show the calendar the event is being created on. For that reason, the buttons at the top right side stick out into the title field when using the quick view:
  • Adding a file to an event (both upload and select existing file)
  • Editing an reminder (only closes when removing reminder -> no more reminders there afterwards)

Broken upstream

  • Creating a new calendar (only exception: add public holiday calendar)

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

Migrate to Vue 3

3 participants