Open
Conversation
Contributor
Author
|
Initial testable vue 3 migration |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
1012416 to
38fb190
Compare
3 tasks
Contributor
|
I added the new datepicker, however it requires this: nextcloud-libraries/nextcloud-vue#8009 |
78c2d28 to
48a338d
Compare
ca33524 to
cb4fb62
Compare
97eba73 to
a24efcb
Compare
DerDreschner
requested changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
I found the following issues (using Firefox, btw):
- Creating a new event, editing an existing one or viewing a read-only one doesn't show the option to select/show the calendar the event is being created on. For that reason, the buttons at the top right side stick out into the title field when using the quick view:
- The menu doesn't close when clicking on an item in the follow cases:
- Creating a new calendar (only exception: add public holiday calendar)
- Adding a file to an event (both upload and select existing file)
- Editing an reminder (only closes when removing reminder -> no more reminders there afterwards)
- When using the day view and having multiple events at the same time, it looks pretty odd? Somethings wrong there.
- When opening "Add public holiday calendar" and "Repeat event", there is a new text in the top middle? But only in those cases? Don't know if that's desired, it irrated me as that are the only two cases an modal overlay creates that.
- When editing the first notification of an event, the menu button sticks out into the drop-down selection field:
- The input fields are not on the same line of sight here:
a24efcb to
2819dba
Compare
Contributor
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com> Signed-off-by: Grigory V <scratchx@gmx.com>
2819dba to
3e0bd47
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Contributor
Author
|
Thanks for testing @DerDreschner ! The styling issues will be addressed in a few follow up PR's as per our team call conversation. There is also one issue that seems to be caused by a broken upstream component. Style issues
New to vue 9
Fixed
Broken upstream
|
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


















Summary
Testing