Skip to content

fix(PageList): Scroll favored page in page list into viewport#1697

Merged
mejo- merged 1 commit intomainfrom
fix/page_list_scroll
Apr 14, 2025
Merged

fix(PageList): Scroll favored page in page list into viewport#1697
mejo- merged 1 commit intomainfrom
fix/page_list_scroll

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented Apr 1, 2025

Also fixes scrolling the active page into viewport when it's a favored page.

Fixes: #1673

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- requested a review from a team April 1, 2025 12:36
@mejo- mejo- self-assigned this Apr 1, 2025
@mejo- mejo- requested a review from max-nextcloud as a code owner April 1, 2025 12:36
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Apr 1, 2025
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Apr 1, 2025
Also fixes scrolling the active page into viewport when it's a favored
page.

Fixes: #1673

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/page_list_scroll branch from 6d200f4 to 9365b50 Compare April 1, 2025 12:50
@mejo- mejo- merged commit aa8ae2e into main Apr 14, 2025
51 checks passed
@mejo- mejo- deleted the fix/page_list_scroll branch April 14, 2025 10:13
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Clicking on a favorite could scroll it in view in the pages list below for added context

2 participants