Skip to content

fix(landingpage): Do not show the Team Overview button on public share#1710

Closed
tintou wants to merge 2 commits intonextcloud:mainfrom
tintou:tintou/overview-public
Closed

fix(landingpage): Do not show the Team Overview button on public share#1710
tintou wants to merge 2 commits intonextcloud:mainfrom
tintou:tintou/overview-public

Conversation

@tintou
Copy link
Copy Markdown
Contributor

@tintou tintou commented Apr 9, 2025

📝 Summary

Do not show the Team Overview button on public share

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

One need to be logged-in to see the team overview anyway.

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution, much appreciated 🙏

Signed-off-by: Jonas <jonas@nextcloud.com>
@mejo-
Copy link
Copy Markdown
Member

mejo- commented Apr 23, 2025

I pushed your commit into a new PR to fix the rebase conflicts in this one. #1729

@mejo- mejo- closed this Apr 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants