Skip to content

fix(landingpage): Do not show the Show Templates button on public share#1711

Merged
mejo- merged 1 commit intonextcloud:mainfrom
tintou:tintou/template-public
Apr 23, 2025
Merged

fix(landingpage): Do not show the Show Templates button on public share#1711
mejo- merged 1 commit intonextcloud:mainfrom
tintou:tintou/template-public

Conversation

@tintou
Copy link
Copy Markdown
Contributor

@tintou tintou commented Apr 9, 2025

📝 Summary

The user is not going to do some edition at this point, do not allow them to list the templates.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, much appreciated! I left a comment.

Comment thread src/components/PageList.vue Outdated
Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes.

The user is not going to do some edition at this point.

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
@tintou tintou force-pushed the tintou/template-public branch from 170d39c to 8812380 Compare April 16, 2025 12:22
@tintou tintou requested a review from mejo- April 16, 2025 12:24
@mejo- mejo- merged commit c025a1a into nextcloud:main Apr 23, 2025
51 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide the templates when looking at a document read-only

2 participants