Skip to content

Refactor page vue components#1712

Merged
mejo- merged 5 commits intomainfrom
refactor/page_frontend
Apr 14, 2025
Merged

Refactor page vue components#1712
mejo- merged 5 commits intomainfrom
refactor/page_frontend

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented Apr 9, 2025

📝 Summary

Aims to simplify and clean the code structure. Shouldn't introduce user-visible changes.

  • Move the page title bar into its own component
  • Move the page title form into its own component (reused in PageTitleBar and PageVersion)
  • Move page and page title related CSS rules into their respective components (less generic CSS in editor.scss and Collective.vue)
  • Simplify logic to differentiate between sheet and full-width view by moving the selectors into their respective components

I manually tested (where applicable combinations of):

  • Normal page and page version view
  • Sheet and full-width view
  • Desktop and mobile view
  • Landing page
  • Empty pages and pages with long content

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

mejo- added 2 commits April 9, 2025 12:08
Signed-off-by: Jonas <jonas@freesources.org>
Try to move more CSS into the components.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- self-assigned this Apr 9, 2025
@mejo- mejo- requested a review from max-nextcloud as a code owner April 9, 2025 14:03
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Apr 9, 2025
@mejo- mejo- force-pushed the refactor/page_frontend branch 2 times, most recently from e200e48 to 2cc76c6 Compare April 9, 2025 15:21
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Apr 9, 2025
@mejo- mejo- requested review from a team and marcoambrosini April 9, 2025 16:04
Comment thread src/components/Page/PageTitleBar.vue
Comment thread src/components/Page/PageTitleBar.vue Outdated
mejo- added 2 commits April 15, 2025 01:11
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the refactor/page_frontend branch from 2cc76c6 to 43372fd Compare April 14, 2025 23:24
… cypress

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the refactor/page_frontend branch from 43372fd to faf643e Compare April 14, 2025 23:26
@mejo- mejo- merged commit d44386c into main Apr 14, 2025
51 checks passed
@mejo- mejo- deleted the refactor/page_frontend branch April 14, 2025 23:42
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants