Skip to content

don't filter results while sharing #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

don't filter results while sharing #3782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/components/AppNavigation/Settings/SettingsAddressbookShare.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
:placeholder="placeholder"
:class="{ 'showContent': inputGiven, 'icon-loading': isLoading }"
:user-select="true"
:filter-by="filterResults"
open-direction="bottom"
track-by="user"
label="displayName"
Expand Down Expand Up @@ -107,6 +108,18 @@ export default {
shareAddressbook({ user, displayName, uri, isGroup }) {
this.$store.dispatch('shareAddressbook', { addressbook: this.addressbook, user, displayName, uri, isGroup })
},
/**
* Function to filter results in NcSelect
*
* @param {object} option
* @param {string} label
* @param {string} search
*/
/* eslint-disable @typescript-eslint/no-unused-vars */
Copy link
Member

@ChristophWurst ChristophWurst Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to drop the arguments from the function instead of the eslint line

filterResults(option, label, search) {
return true
},
/* eslint-enable @typescript-eslint/no-unused-vars */

/**
* Use the cdav client call to find matches to the query from the existing Users & Groups
Expand Down