Skip to content

fix: add member in circles view instead of trying to add contacts #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 15, 2025

@susnux susnux requested a review from skjnldsv May 15, 2025 13:02
@susnux susnux requested review from hamza221 and GVodyanov as code owners May 15, 2025 13:02
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: teams ex circles labels May 15, 2025
@susnux
Copy link
Contributor Author

susnux commented May 15, 2025

@hamza221 could you help afterwards with backport? Not sure which branches you use for backporting down to stable29

Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 11.02%. Comparing base (e026a6c) to head (0c86b28).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/views/Contacts.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4470      +/-   ##
============================================
- Coverage     11.03%   11.02%   -0.02%     
  Complexity      265      265              
============================================
  Files           122      122              
  Lines          5589     5595       +6     
  Branches       1209     1213       +4     
============================================
  Hits            617      617              
- Misses         4850     4856       +6     
  Partials        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hamza221
Copy link
Contributor

/backport to stable7.1

@hamza221
Copy link
Contributor

/backport to stable6.0

@susnux susnux merged commit e53f82a into main May 28, 2025
55 of 59 checks passed
@susnux susnux deleted the fix/teams-add-contact branch May 28, 2025 13:22
Copy link

welcome bot commented May 28, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: teams ex circles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of empty contacts while having a circle opened
3 participants