fix: use untranslated category for grouping contacts #4664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4664 +/- ##
=========================================
Coverage 10.94% 10.94%
Complexity 291 291
=========================================
Files 127 127
Lines 6552 6552
Branches 1204 1204
=========================================
Hits 717 717
Misses 5713 5713
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kesselb
force-pushed
the
fix/translate-recently-contacted-only-for-labeling
branch
from
4a349d8 to
9768dd9
Compare
kesselb
added
3. to review
hamza221
approved these changes
Oct 7, 2025
The grouping in contacts is done by the categories attribute. The cards created for recently contacted are using a translated string for the category. This leads to a weird state when a user switched languages inbetween. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
fix/translate-recently-contacted-only-for-labeling
branch
from
9768dd9 to
f7c0c7d
Compare
Contributor
Author
|
/backport to stable8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4663 for additional context and steps to reproduce.
The grouping in contacts is done by the categories attribute. The cards created for recently contacted are using a translated string for the category. This leads to a weird state when a user switched languages inbetween.
The notable difference in contacts is that the category name is translated, but we are always using "Recently contacted" in the url.