fix: avoid fetching the user's addressbooks per component instance

[kesselb]

How to test:

• The easiest way is by patching the mail app at https://github.com/nextcloud/mail/blob/684e75a46d208bc6365b328e8c85df84e638354b/src/components/RecipientInfo.vue#L52-L54 and replace v-if with v-show.
• Open an email that was sent to 3 or more recipients and press reply all

Before: You should see one request for each recipient to PROPFIND /remote.php/dav/principals/users/alice/ and PROPFIND /remote.php/dav/addressbooks/users/alice/

After: You should see only one request to PROPFIND /remote.php/dav/principals/users/alice/ and PROPFIND /remote.php/dav/addressbooks/users/alice/

[kesselb]

This isn’t exactly what Richard suggested, but I dropped that approach because I couldn’t get it to work. In hindsight, I think the idea itself was fine, but I realized too late that the Vuex store was already shared between components, while the Pinia instances were not. Since I created a new Pinia store for it, that was probably the issue I was running into.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.04%. Comparing base (b977fd8) to head (7bbe969).
⚠️ Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
src/views/ReadOnlyContactDetails.vue	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #4794   +/-   ##
=========================================
  Coverage     11.04%   11.04%           
  Complexity      293      293           
=========================================
  Files           127      127           
  Lines          6565     6563    -2     
  Branches       1204     1204           
=========================================
  Hits            725      725           
+ Misses         5718     5716    -2     
  Partials        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ChristophWurst]

The shared pinia store + this should do the trick, right? The promise hack seems superfluous

[kesselb]

I'm afraid not. The shared pinia store is the requirement to make the promise hack work 🙈

[kesselb]

I'm going to revert this line as it's actually unrelated.

[ChristophWurst]

Huh. I was pretty sure that moving the flag toggle up could solve the issue elegantly. The first call of the action actually fetches addressbooks the other ones return early. This is fine if the result of the action is not used but address books populate reactively once loaded.