fix(ContactsSettings): redo

[GVodyanov]

Fix #4785

Here's how it's looking with the current state of the Nextcloud-vue components

[codecov]

Codecov Report

❌ Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../AppNavigation/Settings/SettingsNewAddressbook.vue	0.00%	26 Missing ⚠️
...nts/AppNavigation/Settings/SettingsAddressbook.vue	0.00%	7 Missing ⚠️
src/components/AppNavigation/ContactsSettings.vue	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[ChristophWurst]

@GVodyanov please change the commit message to fix: xxx. style if for coding style changes.

@hamza221 @SebastianKrupinski please test/review so we can get this in ASAP to give translators a chance to cover the new strings before the release.

[hamza221]

Clicking on "New address book" should open the input field that was previously top-level in a dialog titled "New address book", with options to "Cancel" or "Add" (primary).

• no cancel/add buttons
• On submit I would expect to revert back to the button ? (or at least on cancel)

• Sort by select is broken (can't pick value)
• Update avatars from social media should come after the sorting NcSelect according to the mockup

[hamza221]

/backport to stable8.1

[hamza221]

/backport to stable8.0

[ChristophWurst]

Given the translation string changes this shouldn't be backported too far. The goal is to have these changes released by server 32.0.2 release date.

[hamza221]

Given the translation string changes this shouldn't be backported too far. The goal is to have these changes released by server 32.0.2 release date.

So down to 8.0

[GVodyanov]

Clicking on "New address book" should open the input field that was previously top-level in a dialog titled "New address book", with options to "Cancel" or "Add" (primary).

* no cancel/add buttons

* On submit I would expect to revert back to the button ? (or at least on cancel)


* [ ]  Sort by select is broken (can't pick value)

* [ ]  Update avatars from social media should come after the sorting NcSelect according to the mockup

Right so sort by select being broken is something I decided to move to another PR #4804

I'll do the rest now

[GVodyanov]

I also converted the custom addressbook list into NcListItems

[ChristophWurst]

Squash seems to have gone wrong. Only the commit message of the first commit should be taken

[kra-mo]

Same note as for Calendar. "Sort by" now uses NcFormBoxSelectNative.

[hamza221]

Same note as for Calendar. "Sort by" now uses NcFormBoxSelectNative.

Can you please resolve conflicts and address this 👆🏼

[GVodyanov]

Same note as for Calendar. "Sort by" now uses NcFormBoxSelectNative.

Can you please resolve conflicts and address this 👆🏼

NcFormBoxSelectNative has not been merged or released yet, it is still in a draft state. Meanwhile this PR is pretty time critical so that component will be implemented as a follow up.

[GVodyanov]

Having said all of this, apparently @nfebe accidentally created a duplicate of this PR here #4865

After talking with him, we agreed that we will use his PR. It's newer and has all the Nextcloud vue components that weren't released at the time of creation of my PR. Please go ahead and review that one: #4865