[stable7.3] Improve filtering contacts, especially for phone numbers #4840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
… book Fixes filtering for phone numbers in the contact list filter. Fixes: #3112 Signed-off-by: Jonas <[email protected]>
…rchData When filtering contacts by filter string in the contacts list, one does not expect to get contacts listed where CardDAV metadata fields match. Also, filtering for 'tel' or 'email' should not return all contacts just because they all have a CardDAV field of the same name. Fixes: #1176 Signed-off-by: Jonas <[email protected]>
Allows to find numbers like "(212) 12 34 56" with filter string "21212". Signed-off-by: Jonas <[email protected]>
hamza221
force-pushed
the
backport/4834/stable7.3
branch
from
72535e7 to
ada58fe
Compare
hamza221
approved these changes
Nov 3, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable7.3 #4840 +/- ##
==============================================
- Coverage 9.93% 9.91% -0.02%
Complexity 266 266
==============================================
Files 124 124
Lines 6183 6195 +12
Branches 1430 1432 +2
==============================================
Hits 614 614
- Misses 5446 5457 +11
- Partials 123 124 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hamza221
force-pushed
the
backport/4834/stable7.3
branch
from
ada58fe to
b3a13e9
Compare
Filtering for `+` made the frontend throw a SyntaxError as `+` is an invalid regex. Fix this by catching the error and doing simple string comparison in this case. Fixes e.g. typing `+212` in the search field. Signed-off-by: Jonas <[email protected]>
hamza221
force-pushed
the
backport/4834/stable7.3
branch
from
b3a13e9 to
9cb45fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4834
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.