Skip to content

Conversation

@maystar
Copy link
Contributor

@maystar maystar commented Nov 9, 2025

This change adapts the events for CheckboxRadioSwitch from @nextcloud/vue in version 9.x.x. I'm not sure if all broken interfaces are fixed, but at least the checkboxes in the CircleDetails component work again.

This fixes #4854.

@maystar maystar force-pushed the fix-checkbox-radio-switch-in-circle-details branch from c3194c4 to 56510b2 Compare November 9, 2025 21:43
@hamza221 hamza221 requested a review from nfebe November 10, 2025 15:31
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews feature: teams ex circles labels Nov 10, 2025
@hamza221
Copy link
Contributor

Hello,
Thank you for the fix,
Can you please sign the commit and make it conventional

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/CircleDetails/CircleSettings.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@maystar maystar force-pushed the fix-checkbox-radio-switch-in-circle-details branch 2 times, most recently from 1a7eb4b to 3b2e7bc Compare November 10, 2025 21:17
@maystar
Copy link
Contributor Author

maystar commented Nov 16, 2025

Hello, Thank you for the fix, Can you please sign the commit and make it conventional

This is done! What are the next steps to get rid of the issue on productive systems?

@GVodyanov
Copy link
Contributor

Could you please run git commit --amend --signoff

@maystar maystar force-pushed the fix-checkbox-radio-switch-in-circle-details branch from 3b2e7bc to d05e7ce Compare November 18, 2025 20:18
@maystar
Copy link
Contributor Author

maystar commented Nov 18, 2025

Could you please run git commit --amend --signoff

I did it again. I don't know what's wrong with my first signoff. I'm not familiar with this git feature. If there is still an issue with the commit please just copy this trivial change to the code base in order to make the circle app work again!

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@hamza221 hamza221 force-pushed the fix-checkbox-radio-switch-in-circle-details branch from d05e7ce to 919b7fd Compare November 24, 2025 14:25
@hamza221 hamza221 force-pushed the fix-checkbox-radio-switch-in-circle-details branch from 919b7fd to 4cff865 Compare November 24, 2025 14:26
@hamza221 hamza221 enabled auto-merge November 24, 2025 14:26
@hamza221
Copy link
Contributor

/backport to stable8.1

@hamza221 hamza221 merged commit ed5671b into nextcloud:main Nov 24, 2025
42 of 43 checks passed
@welcome
Copy link

welcome bot commented Nov 24, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: teams ex circles feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkboxes in Team/Circle Settings have no effect

3 participants