-
Notifications
You must be signed in to change notification settings - Fork 196
Fix checkbox radio switch in circle details #4857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checkbox radio switch in circle details #4857
Conversation
c3194c4 to
56510b2
Compare
|
Hello, |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1a7eb4b to
3b2e7bc
Compare
This is done! What are the next steps to get rid of the issue on productive systems? |
|
Could you please run |
3b2e7bc to
d05e7ce
Compare
I did it again. I don't know what's wrong with my first signoff. I'm not familiar with this git feature. If there is still an issue with the commit please just copy this trivial change to the code base in order to make the circle app work again! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
d05e7ce to
919b7fd
Compare
Signed-off-by: Fabian <[email protected]> Signed-off-by: Hamza <[email protected]>
919b7fd to
4cff865
Compare
|
/backport to stable8.1 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This change adapts the events for CheckboxRadioSwitch from @nextcloud/vue in version 9.x.x. I'm not sure if all broken interfaces are fixed, but at least the checkboxes in the CircleDetails component work again.
This fixes #4854.