feat: use lazy app config values and small fixes #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
approved these changes
Nov 14, 2025
kyteinsky
commented
Nov 14, 2025
Contributor
Author
kyteinsky
left a comment
kyteinsky
left a comment
There was a problem hiding this comment.
a few confusion points here. It'd nice to have a piece of your mind on them.
kyteinsky
force-pushed
the
feat/lazy-config
branch
from
32e3702 to
2f19e88
Compare
kyteinsky
force-pushed
the
feat/lazy-config
branch
from
0cb32e7 to
bca71e7
Compare
- use `isEnabledForAnyone` instead of `isInstalled` to check for app_api - type annotations for both OCP and the OCA IContentProvider - make `indexed_files_count` app config non-lazy Signed-off-by: Anupam Kumar <[email protected]>
- use `isEnabledForAnyone` instead of `isInstalled` to check for app_api - type annotations for both OCP and the OCA IContentProvider - make `indexed_files_count` app config non-lazy Signed-off-by: Anupam Kumar <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
kyteinsky
force-pushed
the
feat/lazy-config
branch
from
bca71e7 to
9976be0
Compare
marcelklehr
reviewed
Nov 24, 2025
| } | ||
|
|
||
| $qb = $this->connection->getQueryBuilder(); | ||
| $qb->update('appconfig') |
Member
There was a problem hiding this comment.
Mmh, why are you bypassing the Appconfig interface? The db table is not guaranteed to be stable, while the OCP interface is
Contributor
Author
There was a problem hiding this comment.
it would be hard to guess if the config was originally set or not so we might end up setting it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isEnabledForAnyoneinstead ofisInstalledto check for app_api