-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip exporting a deleted card #6692
Conversation
🐢 Performance warning. |
🐢 Performance warning. |
@luka-nextcloud @grnd-alt I never touched any of the integration tests, so I'm not sure why the query count would have increased. The only tests I added were unit tests, which I would assume would also increase the query count since the command makes database queries. Are unit tests included in the query diff? The message is a bit confusing. |
@grnd-alt I cannot figure out why it says the number of database queries has increased. If anything, the changes should make it query the database less. And the unit tests, from what I can see, should not be affecting it. Am I missing something? Maybe @luka-nextcloud can have a look? |
Signed-off-by: Elizabeth Danzberger <[email protected]>
🐢 Performance warning. |
/backport to stable31 |
/backport to stable30 |
/backport to stable29 |
@elzody It is the query count total, not slow query. I guess it might be related to the update of server repository. It's just a few queries of increasing. We just need to update the |
Summary
Checks if the card is deleted before continuing -- if it is, just move on
Checklist