feat: refactor activity window into own folder structure#10350
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 266bca3edf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
@copilot resolve the merge conflicts in this pull request |
Signed-off-by: Rello <github@scherello.de>
…ned SyncStatusSummary before showing it. Signed-off-by: Rello <github@scherello.de>
c2a23ed to
1910cdb
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-10350.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Signed-off-by: Rello <Rello@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b54174cffb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| void slotTriggerDefaultAction(const int activityIndex); | ||
| void slotTriggerAction(const int activityIndex, const int actionIndex); | ||
| void slotTriggerDismiss(const int activityIndex); | ||
| Q_INVOKABLE void sendReplyMessage(const int activityIndex, const QString &conversationToken, const QString &message, const QString &replyTo); |
There was a problem hiding this comment.
This new public Q_INVOKABLE has no Doxygen documentation, despite /workspace/desktop/AGENTS.md requiring: “Document the type and each declared member.” Its behavior for an empty conversation token, message, or replyTo is not evident from the declaration and should be documented; the newly added SyncStatusSummary::loadForAccount() and User::refreshActivities() declarations likewise need the required documentation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa76f9cb8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <file>src/gui/tray/ActivityItemActions.qml</file> | ||
| <file>src/gui/tray/ActivityItemContent.qml</file> | ||
| <file>src/gui/tray/TalkReplyTextField.qml</file> | ||
| <file>src/gui/search/qml/UnifiedSearchInputContainer.qml</file> |
There was a problem hiding this comment.
The commit tree contains these search components directly under src/gui/search/, and a repo-wide git ls-tree check shows there is no src/gui/search/qml/ directory. Because src/gui/CMakeLists.txt passes this file to qt_add_resources, resource generation will fail when it tries to read these nonexistent paths; the search components are already bundled by src/gui/search/CMakeLists.txt via ecm_add_qml_module.
Useful? React with 👍 / 👎.
| {"avatar", user->avatarUrl()}, | ||
| {"name", user->name()}, | ||
| {"server", user->server()}, | ||
| {"accentColor", user->accentColor()}, |
There was a problem hiding this comment.
When an activities window remains cached, this QVariantMap is only a snapshot, so later User::nameChanged, avatarChanged, or accentColorChanged notifications cannot update its header or activity accent color. Those signals are wired to display-name, avatar, and capability changes in User::User, and showActivitiesWindow() reuses the existing window without rebuilding this map, leaving it stale after any such account update; pass the live User object or refresh these properties for cached windows.
Useful? React with 👍 / 👎.
Implemented the Search-style activity modularization.
AI (if applicable)