fix(macOS): Prevent stripping of application name components following a dot in Sparkle update notices#10395
Merged
Merged
Conversation
claucambra
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
July 17, 2026 14:14
claucambra
changed the title
nilsding
approved these changes
Jul 17, 2026
mgallien
force-pushed
the
fix/dot-suffixes.names
branch
from
July 20, 2026 07:11
a2cf229 to
20fcefc
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10395.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
i2h3
approved these changes
Jul 20, 2026
i2h3
left a comment
i2h3
left a comment
Collaborator
There was a problem hiding this comment.
I do not know how the Sparkle problem actually surfaces but the change looks fine. The Swift linting warning appears unrelated.
Collaborator
|
/backport to stable-34.0 please |
…g a dot during Sparkle updates Add CFBundleName and CFBundleDisplayName to MacOSXBundleInfo.plist.in to prevent Sparkle's SUHost name resolving from falling back to file paths and stripping the suffixes Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
mgallien
force-pushed
the
fix/dot-suffixes.names
branch
from
July 20, 2026 10:52
20fcefc to
090111e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add CFBundleName and CFBundleDisplayName to MacOSXBundleInfo.plist.in to prevent Sparkle's SUHost name resolving from falling back to file paths and stripping the suffixes
Checklist
AI (if applicable)