Feature/public links by mgallien · Pull Request #4175 · nextcloud/desktop

mgallien · 2022-01-13T14:16:13Z

No description provided.

sonarqubecloud · 2022-02-08T22:36:47Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

6.1% Coverage
0.0% Duplication

src/gui/tray/usermodel.cpp

src/gui/tray/UserLine.qml

allexzander · 2022-02-09T11:38:34Z

@mgallien How can this be tested?

sonarqubecloud · 2022-05-17T07:58:31Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

6.1% Coverage
0.0% Duplication

mgallien · 2022-07-10T21:35:29Z

@mgallien How can this be tested?

Using a nextcloud server you can create a public share link for a folder
With this link, use it as the server URL when adding a new account and it should just works

codecov · 2022-08-02T21:19:46Z

Codecov Report

Merging #4175 (784bc65) into master (3400df4) will increase coverage by 0.10%.
The diff coverage is 34.48%.

@@            Coverage Diff             @@
##           master    #4175      +/-   ##
==========================================
+ Coverage   56.65%   56.75%   +0.10%     
==========================================
  Files         138      138              
  Lines       17143    17169      +26     
==========================================
+ Hits         9713     9745      +32     
+ Misses       7430     7424       -6

Impacted Files	Coverage Δ
src/libsync/networkjobs.cpp	`49.48% <0.00%> (-0.44%)`	⬇️
src/libsync/account.h	`30.00% <25.00%> (+0.58%)`	⬆️
src/libsync/account.cpp	`38.93% <47.36%> (+0.07%)`	⬆️
src/libsync/syncengine.cpp	`87.20% <0.00%> (+0.54%)`	⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp	`74.25% <0.00%> (+1.82%)`	⬆️
src/libsync/vfs/cfapi/vfs_cfapi.cpp	`87.45% <0.00%> (+2.35%)`	⬆️
src/libsync/vfs/cfapi/hydrationjob.cpp	`56.45% <0.00%> (+3.76%)`	⬆️

sonarqubecloud · 2022-08-03T15:28:57Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

5.5% Coverage
0.0% Duplication

fwcd · 2023-09-15T08:31:56Z

Any updates on this?

lauff · 2024-10-18T07:35:58Z

Is this already working?

sonarqubecloud · 2024-12-03T16:32:38Z

Quality Gate failed

Failed conditions
1 Security Hotspot
3.8% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)
73 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

nextcloud-desktop-bot · 2025-01-23T09:57:17Z

AppImage file: nextcloud-PR-4175-0dc4cc54043f091e2207e943ff09c6c8c3258261-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

nilsding

one small thing, really nice otherwise

side note: when I restarted the client I was prompted to sign in for the public share again, which doesn't really work ... but with the patch from #7768 applied it's fine

src/libsync/account.cpp

sonarqubecloud · 2025-01-23T11:02:48Z

Quality Gate failed

Failed conditions
1 Security Hotspot
3.8% Coverage on New Code (required ≥ 80%)
74 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

sonarqubecloud · 2025-09-30T17:29:21Z

Quality Gate failed

Failed conditions
1 Security Hotspot
3.7% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
118 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

currently sync does not work you can login automatically unles a password is needed in that case, you get a prompt Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Aiiaiiio · 2025-10-02T14:24:13Z

src/gui/owncloudsetupwizard.cpp

    auto newState = manager->addAccount(newAccount);
+
+    if (newAccount->isPublicShareLink()) {
+        qCInfo(lcWizard()) << "seeting up public share link account";


Suggested change

qCInfo(lcWizard()) << "seeting up public share link account";

qCInfo(lcWizard()) << "setting up public share link account";

Aiiaiiio · 2025-10-02T14:25:15Z

src/gui/tray/UserLine.qml

-
-                MenuItem {
-                    text: model.isConnected ? qsTr("Log out") : qsTr("Log in")
+<<<<<<< HEAD


thanks
already fixed

Aiiaiiio · 2025-10-02T14:32:26Z

src/gui/tray/usermodel.cpp


+bool User::canLogout() const
+{
+    return !isPublicShareLink();


Without really knowing the context, reads very weird, that canLogout() doesn't care whether we are logged in.

github-actions · 2025-10-02T14:43:03Z

Artifact containing the AppImage: nextcloud-appimage-pr-4175.zip

Digest: sha256:117197fff079e1c2624b05f1ef231b02b5623c5bcaa3c32a228a8c56672f5392

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

mgallien requested review from allexzander, camilasan and claucambra January 13, 2022 14:16

mgallien linked an issue Jan 13, 2022 that may be closed by this pull request

Allow to add public shared folders to be used on desktop client #4133

Closed

mgallien force-pushed the feature/publicLinks branch 3 times, most recently from ae4ac1d to 044738b Compare January 20, 2022 13:38

mgallien force-pushed the feature/publicLinks branch from 044738b to afcd2b6 Compare February 8, 2022 22:01

mgallien mentioned this pull request Feb 9, 2022

API to query metadata of public share links nextcloud/server#31082

Open

allexzander reviewed Feb 9, 2022

View reviewed changes

src/gui/tray/usermodel.cpp Outdated Show resolved Hide resolved

allexzander reviewed Feb 9, 2022

View reviewed changes

src/gui/tray/UserLine.qml Show resolved Hide resolved

mgallien force-pushed the feature/publicLinks branch from 65ce5af to 02cecd0 Compare May 4, 2022 08:02

mgallien force-pushed the feature/publicLinks branch from 02cecd0 to 844766a Compare May 17, 2022 07:37

mgallien force-pushed the feature/publicLinks branch from 844766a to d02414f Compare June 30, 2022 13:08

mgallien force-pushed the feature/publicLinks branch from d02414f to 0c6a294 Compare July 10, 2022 21:32

mgallien force-pushed the feature/publicLinks branch 2 times, most recently from 5923be1 to 9866f8b Compare August 2, 2022 20:47

mgallien force-pushed the feature/publicLinks branch from 9866f8b to 784bc65 Compare August 3, 2022 15:07

mgallien force-pushed the feature/publicLinks branch from 784bc65 to eddad3b Compare November 29, 2024 11:14

mgallien marked this pull request as ready for review November 29, 2024 13:02

Rello added this to the 3.16.0 milestone Dec 3, 2024

mgallien force-pushed the feature/publicLinks branch from eddad3b to a959b71 Compare December 3, 2024 15:30

mgallien force-pushed the feature/publicLinks branch from a959b71 to 0dc4cc5 Compare January 23, 2025 09:51

mgallien requested review from allexzander and nilsding and removed request for allexzander January 23, 2025 10:00

nilsding requested changes Jan 23, 2025

View reviewed changes

src/libsync/account.cpp Outdated Show resolved Hide resolved

mgallien modified the milestones: 3.16.0, 3.17.0 Feb 10, 2025

mgallien modified the milestones: 3.17.0, 3.18.0 May 26, 2025

mgallien force-pushed the feature/publicLinks branch from 0dc4cc5 to 793f80f Compare September 30, 2025 16:45

mgallien requested review from Aiiaiiio and i2h3 as code owners September 30, 2025 16:45

kra-mo mentioned this pull request Oct 2, 2025

Account wizard redesign #8822

Open

mgallien force-pushed the feature/publicLinks branch from 793f80f to f371d8a Compare October 2, 2025 09:52

mgallien requested a review from nilsding October 2, 2025 09:54

nilsding approved these changes Oct 2, 2025

View reviewed changes

feat: allow usage of public link to shared folders as an account URL

6c14f29

currently sync does not work you can login automatically unles a password is needed in that case, you get a prompt Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

mgallien force-pushed the feature/publicLinks branch from f371d8a to 6c14f29 Compare October 2, 2025 13:42

mgallien enabled auto-merge October 2, 2025 13:42

Aiiaiiio reviewed Oct 2, 2025

View reviewed changes

mgallien merged commit 4ac2a06 into master Oct 2, 2025
19 of 20 checks passed

mgallien deleted the feature/publicLinks branch October 2, 2025 15:05

	qCInfo(lcWizard()) << "seeting up public share link account";
	qCInfo(lcWizard()) << "setting up public share link account";

Conversation

mgallien commented Jan 13, 2022

Uh oh!

sonarqubecloud bot commented Feb 8, 2022

Uh oh!

Uh oh!

Uh oh!

allexzander commented Feb 9, 2022

Uh oh!

sonarqubecloud bot commented May 17, 2022

Uh oh!

mgallien commented Jul 10, 2022

Uh oh!

codecov bot commented Aug 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud bot commented Aug 3, 2022

Uh oh!

fwcd commented Sep 15, 2023

Uh oh!

lauff commented Oct 18, 2024

Uh oh!

sonarqubecloud bot commented Dec 3, 2024

Quality Gate failed

Uh oh!

nextcloud-desktop-bot commented Jan 23, 2025

Uh oh!

nilsding left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 23, 2025

Quality Gate failed

Uh oh!

sonarqubecloud bot commented Sep 30, 2025

Quality Gate failed

Uh oh!

Aiiaiiio Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Aiiaiiio Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

mgallien Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Aiiaiiio Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov bot commented Aug 2, 2022 •

edited

Loading