WIP: Feature/sync folder name #5832
Draft
+52
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 21, 2023 18:37
Signed-off-by: Camila <[email protected]>
…al folder. Signed-off-by: Camila <[email protected]>
Signed-off-by: Camila <[email protected]>
Signed-off-by: Camila <[email protected]>
Signed-off-by: Camila <[email protected]>
|
AppImage file: nextcloud-PR-5832-f13c524ea64b5fe2473b8d580917821cf427ebde-x86_64.AppImage |
|
SonarCloud Quality Gate failed.
|
claucambra
reviewed
Aug 6, 2023
Contributor
claucambra
left a comment
claucambra
left a comment
There was a problem hiding this comment.
A couple of small comments
Comment on lines
+132
to
+136
| QString Theme::appSyncFolderName() const | ||
| { | ||
| return APPLICATION_SYNC_FOLDER_NAME; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Is this new method necessary?
| dlg->setWindowTitle(tr("Create Remote Folder")); | ||
| dlg->setLabelText(tr("Enter the name of the new folder to be created below \"%1\":") | ||
| .arg(parent)); | ||
| .arg(currentItem? |
Contributor
There was a problem hiding this comment.
Suggested change
| .arg(currentItem? | |
| .arg(currentItem ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.