Skip to content

avoid detecting permissions to be invalid on linux NTFS file system #7745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2025

chore: make the permissions reading compatible with windows API

23bb799
Select commit
Loading
Failed to load commit list.
Merged

avoid detecting permissions to be invalid on linux NTFS file system #7745

chore: make the permissions reading compatible with windows API
23bb799
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 24, 2025 in 14m 27s

Quality Gate failed

Failed conditions
193 New Code Smells (required ≤ 0)
2 New Bugs (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 262 in src/libsync/filesystem.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHhXUYKPw_UsE12h&open=AZnsBHhXUYKPw_UsE12h&pullRequest=7745

Check failure on line 386 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHgsUYKPw_UsE114&open=AZnsBHgsUYKPw_UsE114&pullRequest=7745

Check warning on line 373 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "dirent" of type "class std::unique_ptr<struct csync_file_stat_s>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHeoUYKPw_UsE11n&open=AZnsBHeoUYKPw_UsE11n&pullRequest=7745

Check failure on line 1203 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Potential leak of memory pointed to by field 'value' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHgtUYKPw_UsE12U&open=AZnsBHgtUYKPw_UsE12U&pullRequest=7745

Check warning on line 250 in src/gui/folderwatcher.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHT9UYKPw_UsE107&open=AZnsBHT9UYKPw_UsE107&pullRequest=7745

Check warning on line 1142 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "filesDeletedThresholdExceeded" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHgtUYKPw_UsE12E&open=AZnsBHgtUYKPw_UsE12E&pullRequest=7745

Check warning on line 2432 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHkkUYKPw_UsE13k&open=AZnsBHkkUYKPw_UsE13k&pullRequest=7745

Check warning on line 402 in src/libsync/syncengine.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHiQUYKPw_UsE12v&open=AZnsBHiQUYKPw_UsE12v&pullRequest=7745

Check warning on line 326 in src/libsync/filesystem.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"catch" a specific exception type. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHhXUYKPw_UsE12j&open=AZnsBHhXUYKPw_UsE12j&pullRequest=7745

Check warning on line 1608 in src/gui/folder.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHdUUYKPw_UsE11a&open=AZnsBHdUUYKPw_UsE11a&pullRequest=7745

Check failure on line 255 in src/libsync/filesystem.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 50 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHhXUYKPw_UsE12e&open=AZnsBHhXUYKPw_UsE12e&pullRequest=7745

Check warning on line 418 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce this switch case number of lines from 6 to at most 5, for example by extracting code into methods. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHkkUYKPw_UsE13E&open=AZnsBHkkUYKPw_UsE13E&pullRequest=7745

Check warning on line 2344 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "localJob" of type "class OCC::DiscoverySingleLocalDirectoryJob *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHkkUYKPw_UsE13g&open=AZnsBHkkUYKPw_UsE13g&pullRequest=7745

Check warning on line 1590 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "movePerms" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHkkUYKPw_UsE13N&open=AZnsBHkkUYKPw_UsE13N&pullRequest=7745

Check failure on line 1128 in src/libsync/syncengine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHgtUYKPw_UsE12G&open=AZnsBHgtUYKPw_UsE12G&pullRequest=7745

Check failure on line 41 in src/gui/folderwatcher.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this class' destructor so that the class follows the rule of Zero. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHaaUYKPw_UsE109&open=AZnsBHaaUYKPw_UsE109&pullRequest=7745

Check failure on line 1675 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHkkUYKPw_UsE13W&open=AZnsBHkkUYKPw_UsE13W&pullRequest=7745

Check failure on line 685 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHkkUYKPw_UsE13H&open=AZnsBHkkUYKPw_UsE13H&pullRequest=7745

Check warning on line 334 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "parent" of type "class QObject *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHeoUYKPw_UsE11m&open=AZnsBHeoUYKPw_UsE11m&pullRequest=7745

Check warning on line 1188 in src/gui/folder.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHdUUYKPw_UsE11P&open=AZnsBHdUUYKPw_UsE11P&pullRequest=7745

Check warning on line 685 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "result" of type "_Bool" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHkkUYKPw_UsE13I&open=AZnsBHkkUYKPw_UsE13I&pullRequest=7745

Check warning on line 677 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find_if" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHeoUYKPw_UsE11x&open=AZnsBHeoUYKPw_UsE11x&pullRequest=7745

Check warning on line 127 in src/csync/vio/csync_vio_local_unix.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "wuri" of type "const char *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHlfUYKPw_UsE13v&open=AZnsBHlfUYKPw_UsE13v&pullRequest=7745

Check warning on line 333 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "fileSystemReliablePermissions" of type "_Bool" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHeoUYKPw_UsE11l&open=AZnsBHeoUYKPw_UsE11l&pullRequest=7745

Check warning on line 2432 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZnsBHkkUYKPw_UsE13j&open=AZnsBHkkUYKPw_UsE13j&pullRequest=7745
View more details on SonarQubeCloud