-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Height for Resolve Conflicts Dialog #7815
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I have one comment
3a082e0
to
328338c
Compare
@claucambra Done. Thank you |
328338c
to
765d950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution!
I like the idea of the window adapting its height to how many conflicts are present, however the current approach doesn't seem to work well; when you try to resize the window the height keeps changing until 80% of the screen height is reached.
on macOS the window will just be dragged around when I try to resize it, but on my Plasma setup it's more visible:
Screencast_20250206_103808.webm
also please use rebases instead of merges when updating your branch |
@nilsding |
52140eb
to
257e404
Compare
@nilsding I went with the quicker and easier route. Just shrunk the minimum height requirement. |
I prefer windows to be resizable myself, it's especially useful when using screens with different resolutions. surely there's got to be some way to only set the height initially, but for now having a smaller minimum size is fine too. |
Problem:
-With multiple conflicts to fix, sometimes the dialog box would expand beyond the screen in height and could not be resized to a smaller height.
Solution:
-Adjusted height based on content
-Set more reasonable minimum height
Fixes #7785 #6228