Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell_integration/macOS: Upgrade to NextcloudFileProviderKit 2.0 #7824

Merged
merged 7 commits into from
Feb 6, 2025

Conversation

claucambra
Copy link
Collaborator

Adds support for trash enumeration, chunked uploads, etc. in VFS

Copy link

github-actions bot commented Feb 6, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-7824.zip

SHA256 checksum: c5c286c4046e1eb82594c7a13e464bdd30a3cfef0260d22443bb942330f78a40

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarqubecloud bot commented Feb 6, 2025

@mgallien mgallien merged commit ac9af29 into master Feb 6, 2025
14 of 16 checks passed
@mgallien mgallien deleted the feature/ncfpk-2.0 branch February 6, 2025 17:01
@hello-monchi
Copy link

@claucambra There is a major issue with VFC when folder names contain special characters or spaces. If a folder name includes a space or a German umlaut, its contents are not downloaded from Nextcloud, leaving the folder empty and unsynced. Does this PR resolve the issue? Thanks for your great work!

@claucambra
Copy link
Collaborator Author

@claucambra There is a major issue with VFC when folder names contain special characters or spaces. If a folder name includes a space or a German umlaut, its contents are not downloaded from Nextcloud, leaving the folder empty and unsynced. Does this PR resolve the issue? Thanks for your great work!

Unfortunately no, that will require changes to NextcloudFileProviderKit

Thanks for bringing it up, I will take a look

@claucambra
Copy link
Collaborator Author

@claucambra There is a major issue with VFC when folder names contain special characters or spaces. If a folder name includes a space or a German umlaut, its contents are not downloaded from Nextcloud, leaving the folder empty and unsynced. Does this PR resolve the issue? Thanks for your great work!

I have tested this with the latest 3.16.0 release candidate and have not been able to reproduce any issues uploading a file names "pötâtú.txt" so either this was fixed or there may be a server side issue in your case

I encourage you to test 3.16.0 rc1 and see if the issue is fixed

@hello-monchi
Copy link

@claucambra There is a major issue with VFC when folder names contain special characters or spaces. If a folder name includes a space or a German umlaut, its contents are not downloaded from Nextcloud, leaving the folder empty and unsynced. Does this PR resolve the issue? Thanks for your great work!

I have tested this with the latest 3.16.0 release candidate and have not been able to reproduce any issues uploading a file names "pötâtú.txt" so either this was fixed or there may be a server side issue in your case

I encourage you to test 3.16.0 rc1 and see if the issue is fixed

Thank you for checking this out. The issue occurs with special characters in folder names—file names work just fine. To reproduce, create a folder named folder name with spaces via the web interface and add any files inside it. Then, go to Finder and open the folder. The folder will appear empty. Rename the folder to foldernamewithspaces, and the contents of the folder will sync and appear in Finder.

@claucambra
Copy link
Collaborator Author

@claucambra There is a major issue with VFC when folder names contain special characters or spaces. If a folder name includes a space or a German umlaut, its contents are not downloaded from Nextcloud, leaving the folder empty and unsynced. Does this PR resolve the issue? Thanks for your great work!

I have tested this with the latest 3.16.0 release candidate and have not been able to reproduce any issues uploading a file names "pötâtú.txt" so either this was fixed or there may be a server side issue in your case
I encourage you to test 3.16.0 rc1 and see if the issue is fixed

Thank you for checking this out. The issue occurs with special characters in folder names—file names work just fine. To reproduce, create a folder named folder name with spaces via the web interface and add any files inside it. Then, go to Finder and open the folder. The folder will appear empty. Rename the folder to foldernamewithspaces, and the contents of the folder will sync and appear in Finder.

Apologies for not reading your initial comment more carefully. I have tried reproducing the issue with special characters in foldernames but I am still not able to reproduce it on the latest version of the client (master branch); all the files appear correctly for folders with accents or umlauts in the folder name. I encourage you to test 3.16.0 when it is out to see if this issue has been resolved for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants