-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell_integration/macOS: Upgrade to NextcloudFileProviderKit 2.0 #7824
Conversation
Signed-off-by: Claudio Cambra <[email protected]>
…cloudFileProviderKit changes in 2.0 Signed-off-by: Claudio Cambra <[email protected]>
…cking to NextcloudKit 5 Signed-off-by: Claudio Cambra <[email protected]>
…aring to NextcloudKit 5 Signed-off-by: Claudio Cambra <[email protected]>
…lity methods to NextcloudKit 5 Signed-off-by: Claudio Cambra <[email protected]>
…in FileProviderExtension Signed-off-by: Claudio Cambra <[email protected]>
…ion property Signed-off-by: Claudio Cambra <[email protected]>
6a697f5
to
bfe9a97
Compare
Artifact containing the AppImage: nextcloud-appimage-pr-7824.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
@claucambra There is a major issue with VFC when folder names contain special characters or spaces. If a folder name includes a space or a German umlaut, its contents are not downloaded from Nextcloud, leaving the folder empty and unsynced. Does this PR resolve the issue? Thanks for your great work! |
Unfortunately no, that will require changes to NextcloudFileProviderKit Thanks for bringing it up, I will take a look |
I have tested this with the latest 3.16.0 release candidate and have not been able to reproduce any issues uploading a file names "pötâtú.txt" so either this was fixed or there may be a server side issue in your case I encourage you to test 3.16.0 rc1 and see if the issue is fixed |
Thank you for checking this out. The issue occurs with special characters in folder names—file names work just fine. To reproduce, create a folder named |
Apologies for not reading your initial comment more carefully. I have tried reproducing the issue with special characters in foldernames but I am still not able to reproduce it on the latest version of the client (master branch); all the files appear correctly for folders with accents or umlauts in the folder name. I encourage you to test 3.16.0 when it is out to see if this issue has been resolved for you |
Adds support for trash enumeration, chunked uploads, etc. in VFS